Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2151)

Unified Diff: content/renderer/media/media_stream_dependency_factory.cc

Issue 12383016: Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_dependency_factory.cc
diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc
index aa9b7dca0be86cde82161d9b8d4d8000303ca730..332c2b7c334de39b97a58dfa00c80e696a413a08 100644
--- a/content/renderer/media/media_stream_dependency_factory.cc
+++ b/content/renderer/media/media_stream_dependency_factory.cc
@@ -227,6 +227,7 @@ MediaStreamDependencyFactory::CreateRTCPeerConnectionHandler(
}
void MediaStreamDependencyFactory::CreateNativeMediaSources(
+ int render_view_id,
const WebKit::WebMediaConstraints& audio_constraints,
const WebKit::WebMediaConstraints& video_constraints,
WebKit::WebMediaStream* description,
@@ -284,7 +285,7 @@ void MediaStreamDependencyFactory::CreateNativeMediaSources(
const StreamDeviceInfo device_info = source_data->device_info();
if (IsAudioMediaType(device_info.device.type)) {
- if (!InitializeAudioSource(device_info)) {
+ if (!InitializeAudioSource(render_view_id, device_info)) {
DLOG(WARNING) << "Unsupported audio source";
sources_created.Run(description, false);
return;
@@ -486,7 +487,8 @@ MediaStreamDependencyFactory::CreateLocalVideoSource(
}
bool MediaStreamDependencyFactory::InitializeAudioSource(
- const StreamDeviceInfo& device_info) {
+ int render_view_id,
+ const StreamDeviceInfo& device_info) {
DVLOG(1) << "MediaStreamDependencyFactory::InitializeAudioSource()";
// TODO(henrika): the current design does not support a unique source
@@ -500,6 +502,7 @@ bool MediaStreamDependencyFactory::InitializeAudioSource(
// TODO(henrika): refactor \content\public\common\media_stream_request.h
// to allow dependency of media::ChannelLayout and avoid static_cast.
if (!capturer->Initialize(
+ render_view_id,
static_cast<media::ChannelLayout>(device_info.device.channel_layout),
device_info.device.sample_rate, device_info.session_id))
return false;

Powered by Google App Engine
This is Rietveld 408576698