Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: media/audio/audio_output_device_unittest.cc

Issue 12383016: Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_output_device_unittest.cc
diff --git a/media/audio/audio_output_device_unittest.cc b/media/audio/audio_output_device_unittest.cc
index 5628f66748ad27ebdffdb9505a60acf2d1cb21e4..c4981d1917549a66214da36afd7319db868176fc 100644
--- a/media/audio/audio_output_device_unittest.cc
+++ b/media/audio/audio_output_device_unittest.cc
@@ -49,16 +49,13 @@ class MockAudioOutputIPC : public AudioOutputIPC {
MockAudioOutputIPC() {}
virtual ~MockAudioOutputIPC() {}
- MOCK_METHOD1(AddDelegate, int(AudioOutputIPCDelegate* delegate));
- MOCK_METHOD1(RemoveDelegate, void(int stream_id));
-
- MOCK_METHOD2(CreateStream,
- void(int stream_id, const AudioParameters& params));
- MOCK_METHOD1(PlayStream, void(int stream_id));
- MOCK_METHOD1(CloseStream, void(int stream_id));
- MOCK_METHOD2(SetVolume, void(int stream_id, double volume));
- MOCK_METHOD1(PauseStream, void(int stream_id));
- MOCK_METHOD1(FlushStream, void(int stream_id));
+ MOCK_METHOD2(CreateStream, void(AudioOutputIPCDelegate* delegate,
+ const AudioParameters& params));
+ MOCK_METHOD0(PlayStream, void());
+ MOCK_METHOD0(PauseStream, void());
+ MOCK_METHOD0(FlushStream, void());
+ MOCK_METHOD0(CloseStream, void());
+ MOCK_METHOD1(SetVolume, void(double volume));
};
// Creates a copy of a SyncSocket handle that we can give to AudioOutputDevice.
@@ -112,7 +109,7 @@ class AudioOutputDeviceTest
MessageLoopForIO io_loop_;
AudioParameters default_audio_parameters_;
StrictMock<MockRenderCallback> callback_;
- StrictMock<MockAudioOutputIPC> audio_output_ipc_;
+ MockAudioOutputIPC* audio_output_ipc_; // owned by audio_device_
scoped_refptr<AudioOutputDevice> audio_device_;
private:
@@ -155,8 +152,10 @@ AudioOutputDeviceTest::AudioOutputDeviceTest()
CHANNEL_LAYOUT_STEREO, input_channels_,
48000, 16, 1024);
+ audio_output_ipc_ = new MockAudioOutputIPC();
audio_device_ = new AudioOutputDevice(
- &audio_output_ipc_, io_loop_.message_loop_proxy());
+ scoped_ptr<AudioOutputIPC>(audio_output_ipc_),
+ io_loop_.message_loop_proxy());
audio_device_->Initialize(default_audio_parameters_,
&callback_);
@@ -171,8 +170,7 @@ AudioOutputDeviceTest::~AudioOutputDeviceTest() {
void AudioOutputDeviceTest::StartAudioDevice() {
audio_device_->Start();
- EXPECT_CALL(audio_output_ipc_, AddDelegate(_)).WillOnce(Return(kStreamId));
- EXPECT_CALL(audio_output_ipc_, CreateStream(kStreamId, _));
+ EXPECT_CALL(*audio_output_ipc_, CreateStream(audio_device_.get(), _));
io_loop_.RunUntilIdle();
}
@@ -208,7 +206,7 @@ void AudioOutputDeviceTest::ExpectRenderCallback() {
// shared memory section.
const int kMemorySize = CalculateMemorySize();
- EXPECT_CALL(audio_output_ipc_, PlayStream(kStreamId))
+ EXPECT_CALL(*audio_output_ipc_, PlayStream())
.WillOnce(SendPendingBytes(&browser_socket_, kMemorySize));
// We expect calls to our audio renderer callback, which returns the number
@@ -242,8 +240,7 @@ void AudioOutputDeviceTest::WaitUntilRenderCallback() {
void AudioOutputDeviceTest::StopAudioDevice() {
audio_device_->Stop();
- EXPECT_CALL(audio_output_ipc_, CloseStream(kStreamId));
- EXPECT_CALL(audio_output_ipc_, RemoveDelegate(kStreamId));
+ EXPECT_CALL(*audio_output_ipc_, CloseStream());
io_loop_.RunUntilIdle();
}
@@ -278,8 +275,7 @@ TEST_P(AudioOutputDeviceTest, StopBeforeRender) {
// Expect us to shutdown IPC but not to render anything despite the stream
// getting created.
- EXPECT_CALL(audio_output_ipc_, CloseStream(kStreamId));
- EXPECT_CALL(audio_output_ipc_, RemoveDelegate(kStreamId));
+ EXPECT_CALL(*audio_output_ipc_, CloseStream());
CreateStream();
}

Powered by Google App Engine
This is Rietveld 408576698