Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: content/renderer/media/audio_device_factory.h

Issue 12383016: Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_device_factory.h
diff --git a/content/renderer/media/audio_device_factory.h b/content/renderer/media/audio_device_factory.h
index b06ace7aea31af2d27f23ac0b1570c55538151f0..7f2d323393a1bb0879e24a38c397736959fb6f0f 100644
--- a/content/renderer/media/audio_device_factory.h
+++ b/content/renderer/media/audio_device_factory.h
@@ -10,22 +10,27 @@
namespace media {
class AudioInputDevice;
+class AudioOutputDevice;
}
namespace content {
-class RendererAudioOutputDevice;
-
-// A factory for creating RendererAudioOutputDevices. There is a global factory
-// function that can be installed for the purposes of testing to provide
-// a specialized AudioRendererSink class.
+// A factory for creating AudioOutputDevices and AudioInputDevices. There is a
+// global factory function that can be installed for the purposes of testing to
+// provide specialized implementations.
class AudioDeviceFactory {
public:
- // Creates a RendererAudioOutputDevice using the currently registered factory.
- static scoped_refptr<RendererAudioOutputDevice> NewOutputDevice();
-
- // Creates an AudioInputDevice using the currently registered factory,
- static scoped_refptr<media::AudioInputDevice> NewInputDevice();
+ // Creates a AudioOutputDevice using the currently registered factory.
palmer 2013/03/05 21:09:32 NIT: Creates "an"
miu 2013/03/06 22:36:52 Done.
+ // |render_view_id| refers to the render view containing the entity producing
+ // the audio.
+ static scoped_refptr<media::AudioOutputDevice> NewOutputDevice(
+ int render_view_id);
+
+ // Creates an AudioInputDevice using the currently registered factory.
+ // |render_view_id| refers to the render view containing the entity consuming
+ // the audio.
+ static scoped_refptr<media::AudioInputDevice> NewInputDevice(
+ int render_view_id);
protected:
AudioDeviceFactory();
@@ -35,8 +40,8 @@ class AudioDeviceFactory {
// functions to provide alternate audio device implementations.
// If the return value of either of these function is NULL, we fall back
// on the default implementation.
- virtual RendererAudioOutputDevice* CreateOutputDevice() = 0;
- virtual media::AudioInputDevice* CreateInputDevice() = 0;
+ virtual media::AudioOutputDevice* CreateOutputDevice(int render_view_id) = 0;
+ virtual media::AudioInputDevice* CreateInputDevice(int render_view_id) = 0;
private:
// The current globally registered factory. This is NULL when we should

Powered by Google App Engine
This is Rietveld 408576698