Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1560)

Unified Diff: content/browser/renderer_host/media/audio_input_renderer_host.h

Issue 12383016: Merge AssociateStreamWithProducer message into CreateStream message for both audio output and input. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_input_renderer_host.h
diff --git a/content/browser/renderer_host/media/audio_input_renderer_host.h b/content/browser/renderer_host/media/audio_input_renderer_host.h
index d0d4438d23834e159427fab76680e79c7619177f..5385173c2ce609d6031435e8be1383c9a63d2253 100644
--- a/content/browser/renderer_host/media/audio_input_renderer_host.h
+++ b/content/browser/renderer_host/media/audio_input_renderer_host.h
@@ -114,23 +114,22 @@ class CONTENT_EXPORT AudioInputRendererHost
// Methods called on IO thread ----------------------------------------------
+ // Audio related IPC message handlers.
+
// Start the audio input device with the session id. If the device
// starts successfully, it will trigger OnDeviceStarted() callback.
void OnStartDevice(int stream_id, int session_id);
- // Audio related IPC message handlers.
- // Creates an audio input stream with the specified format. If this call is
- // successful this object would keep an internal entry of the stream for the
- // required properties.
+ // Creates an audio input stream with the specified format whose data is
+ // consumed by an entity in the render view referenced by |render_view_id|. If
+ // this call is successful this object would keep an internal entry of the
palmer 2013/03/05 21:09:32 Would keep, or does keep? How does the caller kno
miu 2013/03/06 22:36:52 Clarified the comment.
+ // stream for the required properties.
void OnCreateStream(int stream_id,
+ int render_view_id,
const media::AudioParameters& params,
const std::string& device_id,
bool automatic_gain_control);
- // Track that the data for the audio stream referenced by |stream_id| is
- // consumed by an entity in the render view referenced by |render_view_id|.
- void OnAssociateStreamWithConsumer(int stream_id, int render_view_id);
-
// Record the audio input stream referenced by |stream_id|.
void OnRecordStream(int stream_id);

Powered by Google App Engine
This is Rietveld 408576698