Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 12383010: Change extensions "configure commands" to be "keyboard shortcuts". (Closed)

Created:
7 years, 9 months ago by not at google - send to devlin
Modified:
7 years, 9 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Visibility:
Public.

Description

Change extensions "configure commands" to be "keyboard shortcuts". BUG=173920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185167

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
7 years, 9 months ago (2013-02-28 01:18:02 UTC) #1
Jeffrey Yasskin
https://codereview.chromium.org/12383010/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/12383010/diff/1/chrome/app/generated_resources.grd#newcode5538 chrome/app/generated_resources.grd:5538: + Keyboard shortcuts Should this mention that these are ...
7 years, 9 months ago (2013-02-28 01:27:23 UTC) #2
not at google - send to devlin
Well, it's on chrome://extensions.
7 years, 9 months ago (2013-02-28 01:30:48 UTC) #3
Jeffrey Yasskin
lgtm
7 years, 9 months ago (2013-02-28 01:33:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/12383010/1
7 years, 9 months ago (2013-02-28 01:39:38 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-02-28 06:26:28 UTC) #6
Message was sent while issue was closed.
Change committed as 185167

Powered by Google App Engine
This is Rietveld 408576698