Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1238293005: Preliminary support for Windows manifests in the GN build. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preliminary support for Windows manifests in the GN build. Adds manifest data for content shell. The result matches the GYP build. Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome. BUG=510612 TBR=dpranke@chromium.org Reland of https://codereview.chromium.org/1240893004/ with no cloud print or remoting changes Committed: https://crrev.com/2e2220c02f2bbd3116b7b718aad627f37ad59b92 Cr-Commit-Position: refs/heads/master@{#339709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -6 lines) Patch
A build/config/win/manifest.gni View 1 chunk +182 lines, -0 lines 0 comments Download
A build/win/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A build/win/as_invoker.manifest View 1 chunk +9 lines, -0 lines 0 comments Download
A + build/win/common_controls.manifest View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/shell/BUILD.gn View 3 chunks +4 lines, -1 line 0 comments Download
M testing/test.gni View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brettw
This i sthe same as the previous one but doesn't change the GYP build (previously ...
5 years, 5 months ago (2015-07-21 18:14:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238293005/1
5 years, 5 months ago (2015-07-21 18:16:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 18:56:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2e2220c02f2bbd3116b7b718aad627f37ad59b92 Cr-Commit-Position: refs/heads/master@{#339709}
5 years, 5 months ago (2015-07-21 18:57:53 UTC) #6
Dirk Pranke
5 years, 5 months ago (2015-07-21 19:26:29 UTC) #7
Message was sent while issue was closed.
rs lgtm

Powered by Google App Engine
This is Rietveld 408576698