Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1238253002: MIPS: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. Original commit message: This is the initial round of optimizations for the LoadGlobalViaContextStub and StoreGlobalViaContextStub, basically turning them into platform code stubs to avoid the Crankshaft overhead in the fast case, and making the runtime interface cheaper. BUG=chromium:510694 LOG=n patch from issue 1235063007 at patchset 1 (http://crrev.com/1235063007#ps1)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -44 lines) Patch
M src/mips/code-stubs-mips.cc View 1 chunk +142 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 2 chunks +30 lines, -20 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +142 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 2 chunks +30 lines, -20 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
paul.l...
PTAL, this is for inclusion in https://codereview.chromium.org/1238143002/
5 years, 5 months ago (2015-07-20 06:11:18 UTC) #2
balazs.kilvady
l-g-t-m
5 years, 5 months ago (2015-07-20 09:49:54 UTC) #3
Benedikt Meurer
5 years, 5 months ago (2015-07-24 03:18:29 UTC) #4
Thanks a lot.

Powered by Google App Engine
This is Rietveld 408576698