sdk/lib/html/dart2js/html_dart2js.dart - Issue 12382022: Speeding up Node.nodes.addAll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 12382022: Speeding up Node.nodes.addAll (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 87ba3f1d5cf122a900adb8580cdcff1d7535d571..7b7ad1efecf54df81cccb89b54afff71572cfa34 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -17083,7 +17083,13 @@ class _ChildNodeListLazy implements List {

void addAll(Iterable<Node> iterable) {

if (iterable is _ChildNodeListLazy) {

- iterable = new List.from(iterable);

+ if (iterable._this != _this) {

+ // Optimized route for copying between nodes.

+ for (var i = 0, len = iterable.length; i < len; ++i) {

+ _this.$dom_appendChild(iterable[0]);

+ }

+ return;

}

for (Node node in iterable) {

_this.$dom_appendChild(node);