Issue 1238143003: Added type variable to generic in Stream#take() so that subsequent type checks will work correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1238143003: Added type variable to generic in Stream#take() so that subsequent type checks will work correctly. (Closed)

Created:
5 years, 5 months ago by jriggins

Modified:
5 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Added type variable to generic in Stream#take() so that subsequent type checks will work correctly. FYI: Noob to this process, so hopefully I did things correctly. Thanks. BUG=

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
	M	sdk/lib/async/stream.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	A	tests/lib/async/stream_typecheck_test.dart	View		1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Thank you for the fix. It's a good test (some lines are a too long, ...

5 years, 4 months ago (2015-08-03 09:59:22 UTC) #2

jriggins

5 years, 4 months ago (2015-08-03 19:18:44 UTC) #3

On 2015/08/03 09:59:22, Lasse Reichstein Nielsen wrote:
> Thank you for the fix.
> It's a good test (some lines are a too long, but that's about it).
> It seems the problem is not only with "take", but also with "takeWhile",
"skip",
> "skipWhile" and "distinct", so I'll make a more general fix and test for it.

Sounds great.  Thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages