[stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub.

src/compiler/js-generic-lowering.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-factory.h"
 #include "src/code-stubs.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/js-generic-lowering.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/machine-operator.h"
@@ skipping 320 matching lines @@
   ReplaceWithStubCall(node, callable, flags);
 }
 
 
 void JSGenericLowering::LowerJSLoadGlobal(Node* node) {
   CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);
   const LoadGlobalParameters& p = LoadGlobalParametersOf(node->op());
   if (p.slot_index() >= 0) {
     Callable callable = CodeFactory::LoadGlobalViaContext(isolate(), 0);
     Node* script_context = node->InputAt(0);
-    node->ReplaceInput(0, jsgraph()->SmiConstant(0));
-    node->ReplaceInput(1, jsgraph()->SmiConstant(p.slot_index()));
-    node->ReplaceInput(2, jsgraph()->HeapConstant(p.name()));
-    node->ReplaceInput(3, script_context);  // Replace old context.
+    node->ReplaceInput(0, jsgraph()->Int32Constant(p.slot_index()));
+    node->ReplaceInput(1, jsgraph()->HeapConstant(p.name()));
+    node->ReplaceInput(2, script_context);  // Replace old context.

[Igor Sheludko, 2015/07/18 20:52:43]

// Set new context ...

[Benedikt Meurer, 2015/07/24 05:18:29]

Done.

+    node->RemoveInput(3);

[Igor Sheludko, 2015/07/18 20:52:43]

// ... instead of old one.

[Benedikt Meurer, 2015/07/24 05:18:29]

Done.

     ReplaceWithStubCall(node, callable, flags);
 
   } else {
     Callable callable = CodeFactory::LoadICInOptimizedCode(
         isolate(), p.typeof_mode(), SLOPPY, UNINITIALIZED);
     node->RemoveInput(0);  // script context
     node->InsertInput(zone(), 1, jsgraph()->HeapConstant(p.name()));
     node->InsertInput(zone(), 2, jsgraph()->SmiConstant(p.feedback().index()));
     ReplaceWithStubCall(node, callable, flags);
   }
@@ skipping 35 matching lines @@
 
 
 void JSGenericLowering::LowerJSStoreGlobal(Node* node) {
   CallDescriptor::Flags flags = AdjustFrameStatesForCall(node);
   const StoreGlobalParameters& p = StoreGlobalParametersOf(node->op());
   if (p.slot_index() >= 0) {
     Callable callable =
         CodeFactory::StoreGlobalViaContext(isolate(), 0, p.language_mode());
     Node* script_context = node->InputAt(0);
     Node* value = node->InputAt(2);
-    node->ReplaceInput(0, jsgraph()->SmiConstant(0));
-    node->ReplaceInput(1, jsgraph()->SmiConstant(p.slot_index()));
-    node->ReplaceInput(2, jsgraph()->HeapConstant(p.name()));
-    node->ReplaceInput(3, value);
-    node->ReplaceInput(4, script_context);  // Replace old context.
+    node->ReplaceInput(0, jsgraph()->Int32Constant(p.slot_index()));
+    node->ReplaceInput(1, jsgraph()->HeapConstant(p.name()));
+    node->ReplaceInput(2, value);
+    node->ReplaceInput(3, script_context);  // Replace old context.

[Igor Sheludko, 2015/07/18 20:52:43]

// Set new context ...

[Benedikt Meurer, 2015/07/24 05:18:29]

Done.

+    node->RemoveInput(4);

[Igor Sheludko, 2015/07/18 20:52:43]

// ... instead of old one.

[Benedikt Meurer, 2015/07/24 05:18:29]

Done.

     ReplaceWithStubCall(node, callable, flags);
 
   } else {
     Callable callable = CodeFactory::StoreIC(isolate(), p.language_mode());
     node->RemoveInput(0);  // script context
     node->InsertInput(zone(), 1, jsgraph()->HeapConstant(p.name()));
     if (FLAG_vector_stores) {
       DCHECK(p.feedback().index() != -1);
       node->InsertInput(zone(), 3,
                         jsgraph()->SmiConstant(p.feedback().index()));
@@ skipping 426 matching lines @@
 }
 
 
 MachineOperatorBuilder* JSGenericLowering::machine() const {
   return jsgraph()->machine();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8