Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1238133003: Do not expect verbatim JPY symbol in test. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not expect verbatim JPY symbol in test. The choice for the symbol seems to be locale-dependent. R=jochen@chromium.org BUG=v8:4314 LOG=N Committed: https://crrev.com/d508345123ed0d21afa2e615221dd1827a2982b9 Cr-Commit-Position: refs/heads/master@{#29750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M test/intl/number-format/format-currency.js View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 5 months ago (2015-07-20 10:25:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238133003/1
5 years, 5 months ago (2015-07-20 10:25:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 10:48:27 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-20 10:50:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238133003/1
5 years, 5 months ago (2015-07-20 10:51:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 10:52:40 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 10:53:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d508345123ed0d21afa2e615221dd1827a2982b9
Cr-Commit-Position: refs/heads/master@{#29750}

Powered by Google App Engine
This is Rietveld 408576698