Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Unified Diff: chrome/browser/resources/gesture_config.js

Issue 12381045: chrome://gesture fixes: Fix a couple of issues with form validation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/gesture_config.js
diff --git a/chrome/browser/resources/gesture_config.js b/chrome/browser/resources/gesture_config.js
index 636650da5fb5096faff601d074bf16f874365011..43c95dfce8fb56c81a8a8555c42ff5b5cdad2b78 100644
--- a/chrome/browser/resources/gesture_config.js
+++ b/chrome/browser/resources/gesture_config.js
@@ -58,8 +58,13 @@ GeneralConfig.prototype = {
input.id = field.key;
input.min = field.min || 0;
- if (field.max) input.max = field.max;
- if (field.step) input.step = field.step;
+ if (field.max)
+ input.max = field.max;
+
+ if (field.step)
+ input.step = field.step;
arv (Not doing code reviews) 2013/03/05 19:04:46 or input.step = field.step || 'any';
sadrul 2013/03/05 20:48:52 Done.
+ else
+ input.step = 'any';
if (field.units)
units.innerHTML = field.units;
@@ -254,22 +259,26 @@ function GestureConfig() {
{
key: 'fling_acceleration_curve_coefficient_0',
label: 'Touchscreen Fling Acceleration',
- units: 'x<sup>3</sup>'
+ units: 'x<sup>3</sup>',
+ min: '-1'
},
{
key: 'fling_acceleration_curve_coefficient_1',
label: '+',
- units: 'x<sup>2</sup>'
+ units: 'x<sup>2</sup>',
+ min: '-1'
},
{
key: 'fling_acceleration_curve_coefficient_2',
label: '+',
- units: 'x<sup>1</sup>'
+ units: 'x<sup>1</sup>',
+ min: '-1'
},
{
key: 'fling_acceleration_curve_coefficient_3',
label: '+',
- units: 'x<sup>0</sup>'
+ units: 'x<sup>0</sup>',
+ min: '-1'
},
{
key: 'fling_velocity_cap',
@@ -351,7 +360,8 @@ function WorkspaceCyclerConfig() {
{
key: 'min_brightness',
label: 'Minimum workspace brightness (deepest & shallowest workspace)',
- units: '%'
+ units: '%',
+ min: '-1'
},
{
key: 'background_opacity',
@@ -400,32 +410,38 @@ function FlingConfig() {
{
key: 'touchscreen_alpha',
label: 'Touchscreen fling deacceleration coefficients',
- units: 'alpha'
+ units: 'alpha',
+ min: '-inf'
},
{
key: 'touchscreen_beta',
label: '',
- units: 'beta'
+ units: 'beta',
+ min: '-inf'
},
{
key: 'touchscreen_gamma',
label: '',
- units: 'gamma'
+ units: 'gamma',
+ min: '-inf'
},
{
key: 'touchpad_alpha',
label: 'Touchpad fling deacceleration coefficients',
- units: 'alpha'
+ units: 'alpha',
+ min: '-inf'
},
{
key: 'touchpad_beta',
label: '',
- units: 'beta'
+ units: 'beta',
+ min: '-inf'
},
{
key: 'touchpad_gamma',
label: '',
- units: 'gamma'
+ units: 'gamma',
+ min: '-inf'
},
];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698