chrome://gesture fixes: Fix a couple of issues with form validation.

chrome/browser/resources/gesture_config.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Redefine '$' here rather than including 'cr.js', since this is
 // the only function needed.  This allows this file to be loaded
 // in a browser directly for layout and some testing purposes.
 var $ = function(id) { return document.getElementById(id); };
 
 /**
@@ skipping 40 matching lines @@
 
       var label = row.querySelector('.row-label');
       var input = row.querySelector('.input');
       var units = row.querySelector('.row-units');
 
       label.setAttribute('for', field.key);
       label.textContent = field.label;
       input.id = field.key;
       input.min = field.min || 0;
 
-      if (field.max) input.max = field.max;
-      if (field.step) input.step = field.step;
+      if (field.max)
+        input.max = field.max;
+
+      if (field.step)
+        input.step = field.step;

[arv (Not doing code reviews), 2013/03/05 19:04:46]

or

input.step = field.step || 'any';

[sadrul, 2013/03/05 20:48:52]

Done.

+      else
+        input.step = 'any';
 
       if (field.units)
         units.innerHTML = field.units;
 
       section.querySelector('.section-properties').appendChild(row);
     }
     $('gesture-form').appendChild(section);
   },
 
   /**
@@ skipping 174 matching lines @@
       units: '%'
     },
     {
       key: 'rail_start_proportion',
       label: 'Rail-Start Proportion',
       units: '%'
     },
     {
       key: 'fling_acceleration_curve_coefficient_0',
       label: 'Touchscreen Fling Acceleration',
-      units: 'x<sup>3</sup>'
+      units: 'x<sup>3</sup>',
+      min: '-1'
     },
     {
       key: 'fling_acceleration_curve_coefficient_1',
       label: '+',
-      units: 'x<sup>2</sup>'
+      units: 'x<sup>2</sup>',
+      min: '-1'
     },
     {
       key: 'fling_acceleration_curve_coefficient_2',
       label: '+',
-      units: 'x<sup>1</sup>'
+      units: 'x<sup>1</sup>',
+      min: '-1'
     },
     {
       key: 'fling_acceleration_curve_coefficient_3',
       label: '+',
-      units: 'x<sup>0</sup>'
+      units: 'x<sup>0</sup>',
+      min: '-1'
     },
     {
       key: 'fling_velocity_cap',
       label: 'Touchscreen Fling Velocity Cap',
       units: 'pixels / second'
     }
   ];
 
   return new GeneralConfig(GESTURE_TITLE, GESTURE_PREFIX, GESTURE_FIELDS);
 }
@@ skipping 61 matching lines @@
       units: '%'
     },
     {
       key: 'max_scale',
       label: 'Maximimum workspace scale (scale of shallowest workspace)',
       units: '%'
     },
     {
       key: 'min_brightness',
       label: 'Minimum workspace brightness (deepest & shallowest workspace)',
-      units: '%'
+      units: '%',
+      min: '-1'
     },
     {
       key: 'background_opacity',
       label: 'Desktop background opacity when cycling through workspaces',
       units: '%'
     },
     {
       key: 'distance_to_initiate_cycling',
       label: 'Vertical distance to scroll to initiate cycling',
       units: 'pixels'
@@ skipping 28 matching lines @@
  */
 function FlingConfig() {
   /** @const */ var FLING_TITLE = 'Fling Configuration';
 
   /** @const */ var FLING_PREFIX = 'flingcurve.';
 
   var FLING_FIELDS = [
     {
       key: 'touchscreen_alpha',
       label: 'Touchscreen fling deacceleration coefficients',
-      units: 'alpha'
+      units: 'alpha',
+      min: '-inf'
     },
     {
       key: 'touchscreen_beta',
       label: '',
-      units: 'beta'
+      units: 'beta',
+      min: '-inf'
     },
     {
       key: 'touchscreen_gamma',
       label: '',
-      units: 'gamma'
+      units: 'gamma',
+      min: '-inf'
     },
     {
       key: 'touchpad_alpha',
       label: 'Touchpad fling deacceleration coefficients',
-      units: 'alpha'
+      units: 'alpha',
+      min: '-inf'
     },
     {
       key: 'touchpad_beta',
       label: '',
-      units: 'beta'
+      units: 'beta',
+      min: '-inf'
     },
     {
       key: 'touchpad_gamma',
       label: '',
-      units: 'gamma'
+      units: 'gamma',
+      min: '-inf'
     },
   ];
 
   return new GeneralConfig(FLING_TITLE, FLING_PREFIX, FLING_FIELDS);
 }
 
 
 /**
  * WebUI instance for configuring gesture.* and overscroll.* preference values
  * used by Chrome's gesture recognition system.
@@ skipping 34 matching lines @@
     $(prefName).value = value;
   }
 
   return {
     initialize: initialize,
     getPreferenceValueResult: getPreferenceValueResult
   };
 })();
 
 document.addEventListener('DOMContentLoaded', gesture_config.initialize);