Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 12381045: chrome://gesture fixes: Fix a couple of issues with form validation. (Closed)

Created:
7 years, 9 months ago by sadrul
Modified:
7 years, 9 months ago
CC:
chromium-reviews, arv+watch_chromium.org, DaveMoore
Visibility:
Public.

Description

chrome://gesture fixes: Fix a couple of issues with form validation. * Make sure 'step' is set to 'any' by default. * Assign 'min' values for some of the fields that accept negative values. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186262

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M chrome/browser/resources/gesture_config.js View 1 5 chunks +28 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sadrul
arv@ Please review. davemoore@ FYI
7 years, 9 months ago (2013-03-01 19:36:25 UTC) #1
sadrul
ping
7 years, 9 months ago (2013-03-05 14:18:18 UTC) #2
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/12381045/diff/1/chrome/browser/resources/gesture_config.js File chrome/browser/resources/gesture_config.js (right): https://codereview.chromium.org/12381045/diff/1/chrome/browser/resources/gesture_config.js#newcode65 chrome/browser/resources/gesture_config.js:65: input.step = field.step; or input.step = field.step || ...
7 years, 9 months ago (2013-03-05 19:04:46 UTC) #3
sadrul
https://codereview.chromium.org/12381045/diff/1/chrome/browser/resources/gesture_config.js File chrome/browser/resources/gesture_config.js (right): https://codereview.chromium.org/12381045/diff/1/chrome/browser/resources/gesture_config.js#newcode65 chrome/browser/resources/gesture_config.js:65: input.step = field.step; On 2013/03/05 19:04:46, arv wrote: > ...
7 years, 9 months ago (2013-03-05 20:48:51 UTC) #4
sadrul
7 years, 9 months ago (2013-03-05 21:22:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r186262 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698