Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12381035: Move Mime type handling to streamsPrivate API, so that it works on Desktop Chrome. (Closed)

Created:
7 years, 9 months ago by Zachary Kuznia
Modified:
7 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move Mime type handling to streamsPrivate API, so that it works on Desktop Chrome. BUG=175642 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187536

Patch Set 1 #

Patch Set 2 : Fix base files #

Total comments: 10

Patch Set 3 : Code review fixes #

Patch Set 4 : Missing base files #

Patch Set 5 : Rebase #

Patch Set 6 : Fix broken test #

Patch Set 7 : rebase #

Patch Set 8 : Fix android build #

Patch Set 9 : Initialize test variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -1447 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_handler.h View 1 2 3 4 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler.cc View 1 2 3 4 5 chunks +0 lines, -67 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc View 1 2 3 4 3 chunks +1 line, -29 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_resource_throttle.h View 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_resource_throttle.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc View 1 chunk +0 lines, -407 lines 0 comments Download
D chrome/browser/chromeos/extensions/file_browser_resource_throttle_unittest.cc View 1 2 3 4 1 chunk +0 lines, -330 lines 0 comments Download
A chrome/browser/extensions/api/streams_private/streams_private_api.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc View 1 2 3 4 5 1 chunk +70 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/api/streams_private/streams_resource_throttle.h View 5 chunks +21 lines, -21 lines 0 comments Download
A + chrome/browser/extensions/api/streams_private/streams_resource_throttle.cc View 8 chunks +29 lines, -39 lines 0 comments Download
A + chrome/browser/extensions/api/streams_private/streams_resource_throttle_browsertest.cc View 1 2 3 4 5 6 7 8 13 chunks +32 lines, -40 lines 0 comments Download
A + chrome/browser/extensions/api/streams_private/streams_resource_throttle_unittest.cc View 1 2 3 4 17 chunks +52 lines, -72 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 6 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handler.json View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
chrome/common/extensions/api/streams_private.json View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
chrome/common/extensions/extension_manifest_constants.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 4 chunks +7 lines, -4 lines 0 comments Download
A chrome/common/extensions/mime_types_handler.h View 1 2 3 4 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/common/extensions/mime_types_handler.cc View 1 2 3 4 1 chunk +116 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
chrome/common/extensions_api_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_browser/handle_mime_type/background.js View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_browser/handle_mime_type/manifest.json View 1 chunk +0 lines, -20 lines 0 comments Download
chrome/test/data/extensions/api_test/streams_private/handle_mime_type/background.js View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/streams_private/handle_mime_type/manifest.json View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Zachary Kuznia
Hi Matt, Could you have a look at this change? It's basically a move of ...
7 years, 9 months ago (2013-03-01 07:21:33 UTC) #1
Matt Perry
https://codereview.chromium.org/12381035/diff/2001/chrome/common/extensions/api/_manifest_features.json File chrome/common/extensions/api/_manifest_features.json (right): https://codereview.chromium.org/12381035/diff/2001/chrome/common/extensions/api/_manifest_features.json#newcode186 chrome/common/extensions/api/_manifest_features.json:186: "extension_types": [ "extension", "packaged_app", "platform_app" ] whitelist here too ...
7 years, 9 months ago (2013-03-01 22:15:16 UTC) #2
Zachary Kuznia
https://codereview.chromium.org/12381035/diff/2001/chrome/common/extensions/api/_manifest_features.json File chrome/common/extensions/api/_manifest_features.json (right): https://codereview.chromium.org/12381035/diff/2001/chrome/common/extensions/api/_manifest_features.json#newcode186 chrome/common/extensions/api/_manifest_features.json:186: "extension_types": [ "extension", "packaged_app", "platform_app" ] On 2013/03/01 22:15:16, ...
7 years, 9 months ago (2013-03-04 06:09:43 UTC) #3
Matt Perry
lgtm
7 years, 9 months ago (2013-03-04 21:11:19 UTC) #4
Zachary Kuznia
sky: Could you do an OWNERS review of: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc erg: Could you do an OWNERS ...
7 years, 9 months ago (2013-03-05 05:52:49 UTC) #5
sky
On Mon, Mar 4, 2013 at 9:52 PM, <zork@chromium.org> wrote: > sky: Could you do ...
7 years, 9 months ago (2013-03-05 16:50:22 UTC) #6
Elliot Glaysher
PDM lgtm
7 years, 9 months ago (2013-03-05 19:02:06 UTC) #7
Zachary Kuznia
brettw: Could you do an OWNERS review of: chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc Thanks, -Zach
7 years, 9 months ago (2013-03-05 23:29:36 UTC) #8
brettw
chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc LGTM
7 years, 9 months ago (2013-03-07 22:49:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/12381035/25001
7 years, 9 months ago (2013-03-11 00:53:53 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 9 months ago (2013-03-11 01:22:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/12381035/40001
7 years, 9 months ago (2013-03-11 04:42:49 UTC) #12
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=18162
7 years, 9 months ago (2013-03-11 08:41:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/12381035/41043
7 years, 9 months ago (2013-03-12 02:40:54 UTC) #14
commit-bot: I haz the power
7 years, 9 months ago (2013-03-12 07:56:00 UTC) #15
Message was sent while issue was closed. 
Change committed as 187536

Powered by Google App Engine
This is Rietveld 408576698