Issue 12381002: Improve network stub behavior

Issue 12381002: Improve network stub behavior (Closed)

Created:
7 years, 9 months ago by stevenjb

Modified:
7 years, 9 months ago

Reviewers:
Greg Spencer (Chromium), satorux1

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Improve network stub behavior * Add Devices/Services to Manager client when addded to Device or Service client * Do not include services for disabled technologies in service lists BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185273

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/res/enabled #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+208 lines, -91 lines)			Patch
M	chrome/browser/chromeos/cros/network_library_impl_stub.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chromeos/chromeos_switches.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chromeos/chromeos_switches.cc	View		2 chunks	+9 lines, -3 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View		5 chunks	+49 lines, -32 lines	0 comments	Download
M	chromeos/dbus/shill_device_client_stub.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	chromeos/dbus/shill_manager_client.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/shill_manager_client_stub.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chromeos/dbus/shill_manager_client_stub.cc	View	1	9 chunks	+79 lines, -24 lines	0 comments	Download
M	chromeos/dbus/shill_service_client.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chromeos/dbus/shill_service_client_stub.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chromeos/dbus/shill_service_client_stub.cc	View		6 chunks	+39 lines, -10 lines	0 comments	Download
M	chromeos/network/shill_property_handler_unittest.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

satorux@ - can you take a look at DBusThreadManager? gspencer@ - can you look at ...

7 years, 9 months ago (2013-02-27 23:21:58 UTC) #1

Greg Spencer (Chromium)

lgtm https://codereview.chromium.org/12381002/diff/1/chromeos/dbus/shill_manager_client_stub.cc File chromeos/dbus/shill_manager_client_stub.cc (right): https://codereview.chromium.org/12381002/diff/1/chromeos/dbus/shill_manager_client_stub.cc#newcode417 chromeos/dbus/shill_manager_client_stub.cc:417: bool res = false; nit: Maybe use "result" ...

7 years, 9 months ago (2013-02-27 23:29:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12381002/5001

7 years, 9 months ago (2013-02-28 01:28:34 UTC) #3

stevenjb

7 years, 9 months ago (2013-02-28 17:44:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r185273 (presubmit successful).

Expand Messages | Collapse Messages