Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: Source/core/dom/Node.cpp

Issue 1238083002: Oilpan: Move the EventListener hierarchy to Oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index 016dec1a6d77208db79afa343e2d0d13e346f9e1..a89fd6f2c8c5e664df86d3ae3d068d17ecb57645 100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -1775,7 +1775,7 @@ void Node::didMoveToNewDocument(Document& oldDocument)
}
}
-static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
+static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtrWillBeRawPtr<EventListener> listener, bool useCapture)
{
if (!targetNode->EventTarget::addEventListener(eventType, listener, useCapture))
return false;
@@ -1788,12 +1788,12 @@ static inline bool tryAddEventListener(Node* targetNode, const AtomicString& eve
return true;
}
-bool Node::addEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
+bool Node::addEventListener(const AtomicString& eventType, PassRefPtrWillBeRawPtr<EventListener> listener, bool useCapture)
{
return tryAddEventListener(this, eventType, listener, useCapture);
}
-static inline bool tryRemoveEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
+static inline bool tryRemoveEventListener(Node* targetNode, const AtomicString& eventType, PassRefPtrWillBeRawPtr<EventListener> listener, bool useCapture)
{
if (!targetNode->EventTarget::removeEventListener(eventType, listener, useCapture))
return false;
@@ -1807,7 +1807,7 @@ static inline bool tryRemoveEventListener(Node* targetNode, const AtomicString&
return true;
}
-bool Node::removeEventListener(const AtomicString& eventType, PassRefPtr<EventListener> listener, bool useCapture)
+bool Node::removeEventListener(const AtomicString& eventType, PassRefPtrWillBeRawPtr<EventListener> listener, bool useCapture)
{
return tryRemoveEventListener(this, eventType, listener, useCapture);
}
@@ -1828,7 +1828,7 @@ void Node::removeAllEventListenersRecursively()
}
}
-using EventTargetDataMap = WillBeHeapHashMap<RawPtrWillBeWeakMember<Node>, OwnPtr<EventTargetData>>;
+using EventTargetDataMap = WillBeHeapHashMap<RawPtrWillBeWeakMember<Node>, OwnPtrWillBeMember<EventTargetData>>;
static EventTargetDataMap& eventTargetDataMap()
{
DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<EventTargetDataMap>, map, (adoptPtrWillBeNoop(new EventTargetDataMap())));
@@ -1846,9 +1846,10 @@ EventTargetData& Node::ensureEventTargetData()
return *eventTargetDataMap().get(this);
ASSERT(!eventTargetDataMap().contains(this));
setHasEventTargetData(true);
- EventTargetData* data = new EventTargetData;
- eventTargetDataMap().set(this, adoptPtr(data));
- return *data;
+ OwnPtrWillBeRawPtr<EventTargetData> data = adoptPtrWillBeNoop(new EventTargetData);
+ EventTargetData* dataPtr = data.get();
+ eventTargetDataMap().set(this, data.release());
+ return *dataPtr;
}
#if !ENABLE(OILPAN)

Powered by Google App Engine
This is Rietveld 408576698