Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp - Issue 1238083002: Oilpan: Move the EventListener hierarchy to Oilpan's heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

Issue 1238083002: Oilpan: Move the EventListener hierarchy to Oilpan's heap (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

diff --git a/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp b/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

index b9f2c959913964a9a171ded489b13c6bfa2f3819..0378d4949ed591e434605e9267381e410f00e3c8 100644

--- a/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

+++ b/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp

@@ -54,7 +54,7 @@ void V8WorkerGlobalScopeEventListener::handleEvent(ScriptState* scriptState, Eve

{

// The callback function on XMLHttpRequest can clear the event listener and destroys 'this' object. Keep a local reference to it.

// See issue 889829.

- RefPtr<V8AbstractEventListener> protect(this);

+ RefPtrWillBeRawPtr<V8AbstractEventListener> protect(this);

WorkerScriptController* script = toWorkerGlobalScope(scriptState->executionContext())->script();

if (!script)