chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java - Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Findbugs Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

index 238b24a432c942f7f296493e28142d001c075226..e06ea2370ae8a2c1b167f993103d3a5860770afd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java

@@ -59,11 +59,11 @@ public interface TabCreatorManager {

public abstract Tab launchUrl(String url, TabModel.TabLaunchType type);

/**

- * Creates a Tab to host the given WebContents asynchronously.

+ * Creates a Tab to host the given WebContents.

* @param webContents The web contents to create a tab around.

* @param parentId The id of the parent tab.

* @param type The TabLaunchType describing how this tab was created.

- * @param url URL to display in the WebContents.

+ * @param url URL to show in the Tab. (Needed only for asynchronous tab creation.)

* @return Whether a Tab was created successfully.

public abstract boolean createTabWithWebContents(