chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java - Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Findbugs Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

index 9ee4f4c06b3df4d6bb1d98d36e64076f3ec2abd2..877125e6792aaeabfce536ccd17630411379db40 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

@@ -709,7 +709,7 @@ public class DocumentActivity extends ChromeActivity {

new AsyncTabCreationParams(new LoadUrlParams(url, PageTransition.LINK));

asyncParams.setDocumentStartedBy(DocumentMetricIds.STARTED_BY_CONTEXTUAL_SEARCH);

getTabCreator(false).createNewTab(

- asyncParams, TabLaunchType.FROM_MENU_OR_OVERVIEW, getActivityTab());

+ asyncParams, TabLaunchType.FROM_MENU_OR_OVERVIEW, getActivityTab().getId());

return false;

}