chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java - Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java

Issue 1238053002: Move the WebContents to the AsyncTabCreationParams for tabbed mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Findbugs Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.chrome.browser;	5 package org.chromium.chrome.browser;

6	6

7 import android.content.Context;	7 import android.content.Context;

8	8

9 import org.chromium.chrome.browser.document.DocumentMetricIds;	9 import org.chromium.chrome.browser.document.DocumentMetricIds;

10 import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;	10 import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

(...skipping 26 matching lines...) Expand all Loading...
37	37

38 LoadUrlParams loadUrlParams = new LoadUrlParams(url, PageTransition.LINK );	38 LoadUrlParams loadUrlParams = new LoadUrlParams(url, PageTransition.LINK );

39 loadUrlParams.setPostData(postData);	39 loadUrlParams.setPostData(postData);

40 loadUrlParams.setVerbatimHeaders(extraHeaders);	40 loadUrlParams.setVerbatimHeaders(extraHeaders);

41 loadUrlParams.setReferrer(new Referrer(referrerUrl, referrerPolicy));	41 loadUrlParams.setReferrer(new Referrer(referrerUrl, referrerPolicy));

42	42

43 AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(loadUrlP arams, requestId);	43 AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(loadUrlP arams, requestId);

44 asyncParams.setDocumentStartedBy(intentSource);	44 asyncParams.setDocumentStartedBy(intentSource);

45	45

46 TabDelegate tabDelegate = new TabDelegate(incognito);	46 TabDelegate tabDelegate = new TabDelegate(incognito);

47 tabDelegate.createNewTab(asyncParams, TabLaunchType.FROM_MENU_OR_OVERVIE W, null);	47 tabDelegate.createNewTab(

	48 asyncParams, TabLaunchType.FROM_MENU_OR_OVERVIEW, Tab.INVALID_TA B_ID);

48 }	49 }

49 }	50 }

OLD	NEW