Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 12380074: Wait for the renderer even on WASAPI. (Closed)

Created:
7 years, 9 months ago by DaleCurtis
Modified:
7 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Wait for the renderer even on WASAPI. After weeks of investigation, Henrik has been unable find a WASAPI buffer size that works for all users. Many users are still reporting glitches. Thus its time to put the WaitTillDataReady() back. :( BUG=171651 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185650

Patch Set 1 #

Patch Set 2 : Whoops, uploaded wrong version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M media/audio/audio_output_controller.cc View 1 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
DaleCurtis
This is a tiny, M26 (perhaps even M25) mergeable version of a patch I'll make ...
7 years, 9 months ago (2013-03-01 22:18:59 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 9 months ago (2013-03-01 23:51:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/12380074/1
7 years, 9 months ago (2013-03-01 23:58:45 UTC) #3
DaleCurtis
Committed patchset #2 manually as r185650 (presubmit successful).
7 years, 9 months ago (2013-03-02 01:38:41 UTC) #4
henrika (OOO until Aug 14)
7 years, 9 months ago (2013-03-06 07:44:58 UTC) #5
Message was sent while issue was closed.
Dale, thanks for merging.

Powered by Google App Engine
This is Rietveld 408576698