Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: sdk/lib/io/http_impl.dart

Issue 12380059: Fix type warnings and remove unimplemented stuff from HttpClient interface. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http.dart ('k') | sdk/lib/io/http_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_impl.dart
diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart
index 4f65b855d04ecb9cd8cb3d10a5d41f9d11b034f7..349794d327ef208fd6f2e0b559454ba2d18255a1 100644
--- a/sdk/lib/io/http_impl.dart
+++ b/sdk/lib/io/http_impl.dart
@@ -314,7 +314,7 @@ class _HttpClientResponse
}
-class _HttpOutboundMessage<T> extends IOSink {
+abstract class _HttpOutboundMessage<T> extends IOSink {
// Used to mark when the body should be written. This is used for HEAD
// requests and in error handling.
bool _ignoreBody = false;
@@ -330,7 +330,7 @@ class _HttpOutboundMessage<T> extends IOSink {
}
bool get persistentConnection => headers.persistentConnection;
- bool set persistentConnection(bool p) {
+ void set persistentConnection(bool p) {
headers.persistentConnection = p;
}
@@ -1062,7 +1062,7 @@ class _HttpClient implements HttpClient {
Future<HttpClientRequest> _openUrlFromRequest(String method,
Uri uri,
_HttpClientRequest previous) {
- return openUrl(method, uri).then((request) {
+ return openUrl(method, uri).then((_HttpClientRequest request) {
// Only follow redirects if initial request did.
request.followRedirects = previous.followRedirects;
// Allow same number of redirects.
@@ -1492,7 +1492,7 @@ class _DetachedSocket implements Socket {
void destroy() => _socket.destroy();
void add(List<int> data) => _socket.add(data);
- Future<Socket> close() => _socket.close();
+ void close() => _socket.close();
}
« no previous file with comments | « sdk/lib/io/http.dart ('k') | sdk/lib/io/http_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698