tests/html/xhr_cross_origin_test.dart - Issue 12380046: Future-ify all the html methods and add named parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/html/xhr_cross_origin_test.dart

Issue 12380046: Future-ify all the html methods and add named parameters (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/html/xhr_cross_origin_test.dart

diff --git a/tests/html/xhr_cross_origin_test.dart b/tests/html/xhr_cross_origin_test.dart

index 5f22ee77ca10ed8cdccf5442d397a650faf0a5e5..d4dbecdc13a83f8a0165343f08a1bb31f32a238d 100644

--- a/tests/html/xhr_cross_origin_test.dart

+++ b/tests/html/xhr_cross_origin_test.dart

@@ -33,7 +33,7 @@ main() {

var url = "http://localhost:$port/"

"root_dart/tests/html/xhr_cross_origin_data.txt";

var xhr = new HttpRequest();

- xhr.open('GET', url, true);

+ xhr.open('GET', url, async: true);

var validate = expectAsync1((data) {

expect(data, contains('feed'));

expect(data['feed'], contains('entry'));

« no previous file with comments | « tests/html/fileapi_test.dart ('k') | tests/html/xhr_test.dart » ('j') | no next file with comments »