Issue 12380036: [nacltoons] Add design resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12380036: [nacltoons] Add design resolution. (Closed)

Created:
7 years, 9 months ago by Sam Clegg

Modified:
7 years, 9 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

[nacltoons] Add design resolution. Adding a design resoltuion allows the game to be designed at one resolution and run at another. Also add brush clamping. Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1514

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -15 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	nacltoons/src/app_delegate.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	nacltoons/src/physics_layer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	nacltoons/src/physics_layer.cc	View	1	3 chunks	+28 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/12380036/diff/2001/nacltoons/src/physics_layer.cc File nacltoons/src/physics_layer.cc (right): https://codereview.chromium.org/12380036/diff/2001/nacltoons/src/physics_layer.cc#newcode283 nacltoons/src/physics_layer.cc:283: { nit: { on previous line

7 years, 9 months ago (2013-02-28 23:09:11 UTC) #2

Sam Clegg

7 years, 9 months ago (2013-02-28 23:26:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r1514 (presubmit successful).

Expand Messages | Collapse Messages