Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 12380017: Recognize NaCl OS ABI for all ELF files. (Closed)

Created:
7 years, 9 months ago by halyavin
Modified:
7 years, 9 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master
Visibility:
Public.

Description

Recognize NaCl OS ABI for all ELF files. We had already removed Linux OS ABI. Now we must handle all ELF files, otherwise their architecture is not initialized correctly due to unknown OS ABI. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3313 TEST= ./scons --mode=opt-host,nacl platform=x86-64 bitcode=1 run_gdb_print_symbol_test Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=e7587c3

Patch Set 1 #

Patch Set 2 : added comment #

Patch Set 3 : comment formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M gdb/nacl-tdep.c View 1 2 1 chunk +12 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
halyavin
7 years, 9 months ago (2013-02-28 13:21:26 UTC) #1
eaeltsin
lgtm
7 years, 9 months ago (2013-02-28 13:48:17 UTC) #2
halyavin
7 years, 9 months ago (2013-02-28 13:49:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as re7587c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698