Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Unified Diff: chrome/browser/signin/token_service.cc

Issue 12380006: Build a new TokenCacheService so I can stop using TokenService for something it wasn't designed for. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Token Cache Service - more CR fixes per DCheng Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/token_service.cc
diff --git a/chrome/browser/signin/token_service.cc b/chrome/browser/signin/token_service.cc
index 3fc30397b18d52ec280d6e552b5a8f12fc041b3b..f0b4efd6197321be3849e06ee96e425993bd1aa6 100644
--- a/chrome/browser/signin/token_service.cc
+++ b/chrome/browser/signin/token_service.cc
@@ -100,10 +100,6 @@ void TokenService::Initialize(const char* const source,
}
}
-// TODO(petewil) We should refactor the token_service so it does not both
-// store tokens and fetch them. Move the key-value storage out of
-// token_service, and leave the token fetching in token_service.
-
void TokenService::AddAuthTokenManually(const std::string& service,
const std::string& auth_token) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -420,10 +416,6 @@ void TokenService::LoadTokensIntoMemory(
GaiaConstants::kGaiaOAuth2LoginRefreshToken);
LoadSingleTokenIntoMemory(db_tokens, in_memory_tokens,
GaiaConstants::kGaiaOAuth2LoginAccessToken);
- // TODO(petewil): Remove next line when we refactor key-value
- // storage out of token_service.
- LoadSingleTokenIntoMemory(db_tokens, in_memory_tokens,
- GaiaConstants::kObfuscatedGaiaId);
if (credentials_.lsid.empty() && credentials_.sid.empty()) {
// Look for GAIA SID and LSID tokens. If we have both, and the current

Powered by Google App Engine
This is Rietveld 408576698