Build a new TokenCacheService so I can stop using TokenService for something it wasn't designed for.

chrome/browser/extensions/token_cache/token_cache.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This class caches tokens for the current user.  It will clear tokens out
+// when the user logs out or after the specified timeout interval, or when
+// the instance of chrome shuts down.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_TOKEN_CACHE_TOKEN_CACHE_H_
+#define CHROME_BROWSER_EXTENSIONS_TOKEN_CACHE_TOKEN_CACHE_H_
+
+#include <map>
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "base/time.h"
+#include "chrome/browser/profiles/profile_keyed_service.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+
+namespace content {
+class NotificationSource;
+}
+
+class Profile;
+
+namespace extensions {
+
+struct TokenCacheData {
+  std::string token;
+  base::Time expiration_time;
+};
+
+class TokenCacheService : public ProfileKeyedService,

[Andrew T Wilson (Slow), 2013/03/06 16:55:28]

BTW, technically I think this file should be named token_cache_service.* - it's
non-standard (but not *technically* against the style guide) to put
TokenCacheService inside token_cache.*

So it's your call if you want to leave it like this, but I'd suggest renaming
the files.

+                          public content::NotificationObserver {
+ public:
+  explicit TokenCacheService(Profile* profile);
+  virtual ~TokenCacheService();
+
+  // Store a token for the currently logged in user. We will look it up later by
+  // the name given here, and we will expire the token after the timeout.  For a
+  // timeout of 0, we never expire the token.  After time_to_live expires, the
+  // token will be expired.
+  void StoreToken(const std::string& token_name, const std::string& token_value,
+                  base::TimeDelta time_to_live);
+
+  // Retrieve a token for the currently logged in user.  This returns an empty
+  // string if the token was not found or timed out.
+  std::string RetrieveToken(const std::string& token_name);
+
+  std::map<std::string, TokenCacheData>::iterator FindMatch(

[Andrew T Wilson (Slow), 2013/03/06 16:55:28]

This seems very specific to be exposing as part of your public API. If you want
to expose this for tests, then I'd recommend adding some kind of friend class
statement. You should probably make this private.

[Pete Williamson, 2013/03/06 19:04:31]

Removed

+      const std::string& token_name);
+
+  // inherited from NotificationObserver
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+ private:
+  std::map<std::string, TokenCacheData> token_cache_;
+  content::NotificationRegistrar registrar_;
+  const Profile* const profile_;
+
+  friend class TokenCacheTest;
+
+  DISALLOW_COPY_AND_ASSIGN(TokenCacheService);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_TOKEN_CACHE_TOKEN_CACHE_H_