Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: Source/core/fetch/RawResourceTest.cpp

Issue 1237983003: Revalidate using the same Resource, attempt #2 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/fetch/RawResourceTest.cpp
diff --git a/Source/core/fetch/RawResourceTest.cpp b/Source/core/fetch/RawResourceTest.cpp
index a2452ce4c34407707312fd78ae2941800372fb62..64bae21136e9f21da56324b6dfdda47cae902ccd 100644
--- a/Source/core/fetch/RawResourceTest.cpp
+++ b/Source/core/fetch/RawResourceTest.cpp
@@ -60,26 +60,24 @@ TEST(RawResourceTest, DontIgnoreAcceptForCacheReuse)
TEST(RawResourceTest, RevalidationSucceeded)
{
- // Create two RawResources and set one to revalidate the other.
- RawResource* oldResourcePointer = new RawResource(ResourceRequest("data:text/html,"), Resource::Raw);
- RawResource* newResourcePointer = new RawResource(ResourceRequest("data:text/html,"), Resource::Raw);
- newResourcePointer->setResourceToRevalidate(oldResourcePointer);
- ResourcePtr<Resource> oldResource = oldResourcePointer;
- ResourcePtr<Resource> newResource = newResourcePointer;
- memoryCache()->add(oldResource.get());
- memoryCache()->remove(oldResource.get());
- memoryCache()->add(newResource.get());
+ ResourcePtr<Resource> resource(new RawResource(ResourceRequest("data:text/html,"), Resource::Raw));
+ ResourceResponse response;
+ response.setHTTPStatusCode(200);
+ resource->responseReceived(response, nullptr);
+ const char data[5] = "abcd";
+ resource->appendData(data, 4);
+ resource->finish();
+ memoryCache()->add(resource.get());
// Simulate a successful revalidation.
- // The revalidated resource (oldResource) should now be in the cache, newResource
- // should have been sliently switched to point to the revalidated resource, and
- // we shouldn't hit any ASSERTs.
- ResourceResponse response;
- response.setHTTPStatusCode(304);
- newResource->responseReceived(response, nullptr);
- EXPECT_EQ(memoryCache()->resourceForURL(KURL(ParsedURLString, "data:text/html,")), oldResource.get());
- EXPECT_EQ(oldResource.get(), newResource.get());
- EXPECT_NE(newResource.get(), newResourcePointer);
+ resource->setRevalidatingRequest(ResourceRequest("data:text/html,"));
+ ResourceResponse revalidatingResponse;
+ revalidatingResponse.setHTTPStatusCode(304);
+ resource->responseReceived(revalidatingResponse, nullptr);
+ EXPECT_FALSE(resource->isCacheValidator());
+ EXPECT_EQ(200, resource->response().httpStatusCode());
+ EXPECT_EQ(4u, resource->resourceBuffer()->size());
+ EXPECT_EQ(memoryCache()->resourceForURL(KURL(ParsedURLString, "data:text/html,")), resource.get());
}
class DummyClient : public RawResourceClient {

Powered by Google App Engine
This is Rietveld 408576698