Port more String and HashMap usages

Port more String and HashMap usages

BUG=
R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/b295cbaadd0e20cbd5332832fa15f7cedaf9fc57

[Cutch, 2015-07-15 20:26:50]

johnmccutchan@google.com changed reviewers:
+ abarth@google.com

[abarth-chromium, 2015-07-15 20:42:51]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-07-15 20:42:52]

This is fine except for the slow string building...

https://codereview.chromium.org/1237973004/diff/1/sky/engine/tonic/dart_excep...
File sky/engine/tonic/dart_exception_factory.cc (right):

https://codereview.chromium.org/1237973004/diff/1/sky/engine/tonic/dart_excep...
sky/engine/tonic/dart_exception_factory.cc:23: message.append(" cannot be
null.");
This is super inefficient.  Is there no StringBuilder equivalent for
std::string?

[Cutch, 2015-07-15 22:01:10]

PTAL

[abarth-chromium, 2015-07-16 00:02:25]

LGTM to unblock your work, but see note below.

https://codereview.chromium.org/1237973004/diff/20001/sky/engine/tonic/dart_e...
File sky/engine/tonic/dart_exception_factory.cc (right):

https://codereview.chromium.org/1237973004/diff/20001/sky/engine/tonic/dart_e...
sky/engine/tonic/dart_exception_factory.cc:36: return
CreateException("ArgumentError", message.data());
So ugly...

Sorry to get hung up on this issue.  IMHO, the right thing to do here is to make
a StdStringBuilder class that can build std::strings in a reasonable way.  If
you feel like that's out of scope for this CL, I think it would be ok to go back
to what you had before with a TODO about using a StdStringBuilder instead.

[Cutch, 2015-07-16 14:31:01]

Committed patchset #4 (id:60001) manually as
b295cbaadd0e20cbd5332832fa15f7cedaf9fc57 (presubmit successful).

[Cutch, 2015-07-16 14:31:02]

https://codereview.chromium.org/1237973004/diff/20001/sky/engine/tonic/dart_e...
File sky/engine/tonic/dart_exception_factory.cc (right):

https://codereview.chromium.org/1237973004/diff/20001/sky/engine/tonic/dart_e...
sky/engine/tonic/dart_exception_factory.cc:36: return
CreateException("ArgumentError", message.data());
On 2015/07/16 00:02:24, abarth-chromium wrote:
> So ugly...
> 
> Sorry to get hung up on this issue.  IMHO, the right thing to do here is to
make
> a StdStringBuilder class that can build std::strings in a reasonable way.  If
> you feel like that's out of scope for this CL, I think it would be ok to go
back
> to what you had before with a TODO about using a StdStringBuilder instead.

Done. We can address any follow up comments you have on StdStringBuilder in a
follow up CL.