sky/engine/tonic/dart_snapshot_loader.cc - Issue 1237973002: Remove most usage of Vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/tonic/dart_snapshot_loader.cc

Issue 1237973002: Remove most usage of Vector (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/tonic/dart_snapshot_loader.cc

diff --git a/sky/engine/tonic/dart_snapshot_loader.cc b/sky/engine/tonic/dart_snapshot_loader.cc

index 04b4de01a75836aae57d531a1bf2a8e72a9c3a35..a3b17cf7ab9559f4d4ce37cf8506952cd3def37a 100644

--- a/sky/engine/tonic/dart_snapshot_loader.cc

+++ b/sky/engine/tonic/dart_snapshot_loader.cc

@@ -32,7 +32,8 @@ void DartSnapshotLoader::LoadSnapshot(mojo::ScopedDataPipeConsumerHandle pipe,

}

void DartSnapshotLoader::OnDataAvailable(const void* data, size_t num_bytes) {

- buffer_.append(static_cast<const uint8_t*>(data), num_bytes);

+ const uint8_t* bytes = reinterpret_cast<const uint8_t*>(data);

+ buffer_.insert(buffer_.end(), bytes, bytes + num_bytes);

}

void DartSnapshotLoader::OnDataComplete() {