Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237973002: Remove most usage of Vector (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -17 lines) Patch
M sky/engine/tonic/dart_library_loader.h View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/tonic/dart_library_loader.cc View 1 6 chunks +14 lines, -11 lines 0 comments Download
M sky/engine/tonic/dart_snapshot_loader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/tonic/dart_snapshot_loader.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
5 years, 5 months ago (2015-07-15 14:25:00 UTC) #2
abarth-chromium
LGTM assuming that API does exponential growth. https://codereview.chromium.org/1237973002/diff/1/sky/engine/tonic/dart_library_loader.cc File sky/engine/tonic/dart_library_loader.cc (right): https://codereview.chromium.org/1237973002/diff/1/sky/engine/tonic/dart_library_loader.cc#newcode54 sky/engine/tonic/dart_library_loader.cc:54: buffer_.insert(buffer_.end(), bytes, ...
5 years, 5 months ago (2015-07-15 14:49:32 UTC) #4
kulakowski
https://codereview.chromium.org/1237973002/diff/1/sky/engine/tonic/dart_library_loader.cc File sky/engine/tonic/dart_library_loader.cc (right): https://codereview.chromium.org/1237973002/diff/1/sky/engine/tonic/dart_library_loader.cc#newcode53 sky/engine/tonic/dart_library_loader.cc:53: const uint8_t* bytes = reinterpret_cast<const uint8_t*>(data); Why change |static_cast| ...
5 years, 5 months ago (2015-07-15 15:00:02 UTC) #6
Cutch
5 years, 5 months ago (2015-07-15 16:10:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d3ccba7fc3020a99b103631d3d5fd87411dcd0d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698