Fix omnibox height when less than 64 pixels tall.

Fix omnibox height when less than 64 pixels tall.

Ensure there's always a HandleClientSizeChanged call that happens when the bounds change (even if that doesn't cause the actual bounds of the HWND to change), as otherwise the view size will be stale.

BUG=330123
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244693

[Ben Goodger (Google), 2014-01-09 23:00:06]

https://codereview.chromium.org/123793002/diff/150001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/desktop_root_window_host_win.cc (right):

https://codereview.chromium.org/123793002/diff/150001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/desktop_root_window_host_win.cc:496: // If actual
window size didn't change but the bounds did, then inform the
Your comment just states what the code does.

You could at least rewrite as:

// The client area size may have changed even though the window's bounds have
not.

Bonus points if you can additionally state what condition causes that to happen.

https://codereview.chromium.org/123793002/diff/150001/ui/views/win/hwnd_messa...
File ui/views/win/hwnd_message_handler.cc (right):

https://codereview.chromium.org/123793002/diff/150001/ui/views/win/hwnd_messa...
ui/views/win/hwnd_message_handler.cc:489: return GetWindowBoundsInScreen();
nit: no else after return

[jbauman, 2014-01-14 03:25:45]

PTAL. Should be fixed.

On 2014/01/09 23:00:06, Ben Goodger (Google) wrote:
>
https://codereview.chromium.org/123793002/diff/150001/ui/views/widget/desktop...
> File ui/views/widget/desktop_aura/desktop_root_window_host_win.cc (right):
> 
>
https://codereview.chromium.org/123793002/diff/150001/ui/views/widget/desktop...
> ui/views/widget/desktop_aura/desktop_root_window_host_win.cc:496: // If actual
> window size didn't change but the bounds did, then inform the
> Your comment just states what the code does.
> 
> You could at least rewrite as:
> 
> // The client area size may have changed even though the window's bounds have
> not.
> 
> Bonus points if you can additionally state what condition causes that to
happen.
> 
>
https://codereview.chromium.org/123793002/diff/150001/ui/views/win/hwnd_messa...
> File ui/views/win/hwnd_message_handler.cc (right):
> 
>
https://codereview.chromium.org/123793002/diff/150001/ui/views/win/hwnd_messa...
> ui/views/win/hwnd_message_handler.cc:489: return GetWindowBoundsInScreen();
> nit: no else after return

[Ben Goodger (Google), 2014-01-14 03:27:35]

lgtm

[commit-bot: I haz the power, 2014-01-14 04:56:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/123793002/270001

[commit-bot: I haz the power, 2014-01-14 14:10:22]

Change committed as 244693