Revert "Move Arrays class to private library."

runtime/lib/byte_array.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
 
   /* patch */ factory Int8List.transferable(int length) {
@@ skipping 307 matching lines @@
   void addAll(Iterable value) {
     throw new UnsupportedError(
         "Cannot add to a non-extendable array");
   }
 
   void sort([int compare(var a, var b)]) {
     return IterableMixinWorkaround.sortList(this, compare);
   }
 
   int indexOf(element, [int start = 0]) {
-    return IterableMixinWorkaround.indexOfList(this, element, start);
+    return Arrays.indexOf(this, element, start, this.length);
   }
 
   int lastIndexOf(element, [int start = null]) {
-    return IterableMixinWorkaround.lastIndexOfList(this, element, start);
+    if (start == null) start = length - 1;
+    return Arrays.lastIndexOf(this, element, start);
   }
 
   void clear() {
     throw new UnsupportedError(
         "Cannot remove from a non-extendable array");
   }
 
   int removeLast() {
     throw new UnsupportedError(
         "Cannot remove from a non-extendable array");
@@ skipping 220 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Int8Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-         this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 43 matching lines @@
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Uint8Array || from is _ExternalUint8Array ||
         from is _Uint8ClampedArray || from is _ExternalUint8ClampedArray) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 44 matching lines @@
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Uint8Array || from is _ExternalUint8Array ||
         from is _Uint8ClampedArray || from is _ExternalUint8ClampedArray) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Int16Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Uint16Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Int32Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 43 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Uint32Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Int64Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _Uint64Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<double> from, [int startFrom = 0]) {
     if (from is _Float32Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 42 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<double> from, [int startFrom = 0]) {
     if (from is _Float64Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalInt8Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 29 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalUint8Array || from is _Uint8Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalUint8ClampedArray || from is _Uint8ClampedArray) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 29 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalInt16Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 29 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalUint16Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalInt32Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalUint32Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalInt64Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
     if (from is _ExternalUint64Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<double> from, [int startFrom = 0]) {
     if (from is _ExternalFloat32Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 31 matching lines @@
     return result;
   }
 
   void setRange(int start, int length, List<double> from, [int startFrom = 0]) {
     if (from is _ExternalFloat64Array) {
       _setRange(start * _BYTES_PER_ELEMENT,
                 length * _BYTES_PER_ELEMENT,
                 from,
                 startFrom * _BYTES_PER_ELEMENT);
     } else {
-      IterableMixinWorkaround.setRangeList(
-          this, start, length, from, startFrom);
+      Arrays.copy(from, startFrom, this, start, length);
     }
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
@@ skipping 181 matching lines @@
   void addAll(Iterable value) {
     throw new UnsupportedError(
         "Cannot add to a non-extendable array");
   }
 
   void sort([int compare(var a, var b)]) {
     return IterableMixinWorkaround.sortList(this, compare);
   }
 
   int indexOf(element, [int start = 0]) {
-    return IterableMixinWorkaround.indexOfList(this, element, start);
+    return Arrays.indexOf(this, element, start, this.length);
   }
 
   int lastIndexOf(element, [int start = null]) {
-    return IterableMixinWorkaround.lastIndexOfList(this, element, start);
+    if (start == null) start = length - 1;
+    return Arrays.lastIndexOf(this, element, start);
   }
 
   void clear() {
     throw new UnsupportedError(
         "Cannot remove from a non-extendable array");
   }
 
   int removeLast() {
     throw new UnsupportedError(
         "Cannot remove from a non-extendable array");
@@ skipping 95 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Int8List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Uint8List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Int16List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Uint16List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Int32List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Uint32List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Int64List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<int> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<int> result = new Uint64List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<int> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<double> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<double> result = new Float32List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<double> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
@@ skipping 43 matching lines @@
   }
 
   List<double> getRange(int start, int length) {
     _rangeCheck(this.length, start, length);
     List<double> result = new Float64List(length);
     result.setRange(0, length, this, start);
     return result;
   }
 
   void setRange(int start, int length, List<double> from, [int startFrom = 0]) {
-    IterableMixinWorkaround.setRangeList(this, start, length, from, startFrom);
+    Arrays.copy(from, startFrom, this, start, length);
   }
 
   String toString() {
     return Collections.collectionToString(this);
   }
 
   int bytesPerElement() {
     return _BYTES_PER_ELEMENT;
   }
 
   int lengthInBytes() {
     return length * _BYTES_PER_ELEMENT;
   }
 
   ByteArray asByteArray([int start = 0, int length]) {
     if (length == null) {
       length = this.lengthInBytes();
     }
     _rangeCheck(this.length, start, length);
     return _array.subByteArray(_offset + start, length);
   }
 
   static const int _BYTES_PER_ELEMENT = 8;
 }