Issue 12379082: Remove "library" variable from standalone.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12379082: Remove "library" variable from standalone.gypi. (Closed)

Created:
7 years, 9 months ago by tfarina

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

Remove "library" variable from standalone.gypi. BUG=111541 R=jkummerow@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>; Committed: http://code.google.com/p/v8/source/detail?r=13821

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	build/standalone.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM; I can land this for you. Note that standalone.gypi is not used for Chromium ...

7 years, 9 months ago (2013-03-05 09:26:07 UTC) #2

Jakob Kummerow

7 years, 9 months ago (2013-03-05 09:28:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13821 (presubmit successful).