Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 12379081: Revert 180482 (Closed)

Created:
7 years, 9 months ago by kerz_chromium
Modified:
7 years, 9 months ago
Reviewers:
robertshield, huangs
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Revert 180482 > Merge 179932 - Ensure that ChromeFrame does not interfere with non ChromeFrame requests initiated by IE. > > ChromeFrame patches the urlmon transaction object vtable to ensure that top level requests initiated > by IE are intercepted. Methods patched include the Start/StartEx and Read. The Read method is patched > to ensure that we return unprocessed data back to urlmon in case the site is not switched into ChromeFrame. > > There is a race condition between the time the data is discarded and a new request is created as the > IInternetProtocol interface ptr can be reused. This causes us to return stale data from a previous request to > IE. The data is keyed off the IInternetProtocol interface ptr. > > Fix is to patch the Abort and Terminate methods of the transaction vtable and destroy the data for the protocol. > > Fixes bug http://code.google.com/p/chromium/issues/detail?id=168308 > > BUG=168308 > Review URL: https://chromiumcodereview.appspot.com/12093077 > > TBR=ananta@chromium.org > Review URL: https://chromiumcodereview.appspot.com/12178023 TBR=huangs@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -48 lines) Patch
M chrome_frame/protocol_sink_wrap.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome_frame/protocol_sink_wrap.cc View 4 chunks +2 lines, -44 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kerz_chromium
7 years, 9 months ago (2013-03-04 20:20:59 UTC) #1
kerz_chromium
Committed patchset #1 manually as r185959.
7 years, 9 months ago (2013-03-04 20:21:08 UTC) #2
huangs
I'm unfamiliar with this code, and am not even an OWNER. Please refer to anata@, ...
7 years, 9 months ago (2013-03-04 20:28:27 UTC) #3
robertshield
7 years, 9 months ago (2013-03-04 20:29:37 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698