Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: media/audio/audio_input_ipc.h

Issue 12379071: Use multiple shared memory buffers cyclically for audio capture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_input_ipc.h
===================================================================
--- media/audio/audio_input_ipc.h (revision 185810)
+++ media/audio/audio_input_ipc.h (working copy)
@@ -25,17 +25,21 @@
};
// Called when an AudioInputController has been created.
- // The shared memory |handle| points to a memory section that's used to
- // transfer data between the AudioInputDevice and AudioInputController
- // objects. The implementation of OnStreamCreated takes ownership.
// The |socket_handle| is used by the AudioInputController to signal
// notifications that more data is available and can optionally provide
// parameter changes back. The AudioInputDevice must read from this socket
// and process the shared memory whenever data is read from the socket.
- virtual void OnStreamCreated(base::SharedMemoryHandle handle,
- base::SyncSocket::Handle socket_handle,
- int length) = 0;
+ virtual void OnStreamCreated(base::SyncSocket::Handle socket_handle,
henrika (OOO until Aug 14) 2013/03/04 13:12:51 Nothing is mentioned about |total_handles| here.
wjia(left Chromium) 2013/03/05 02:40:13 Done.
+ int total_handles) = 0;
+ // Called when an AudioInputController has been created.
+ // The shared memory |handle| points to a memory section that's used to
+ // transfer data between the AudioInputDevice and AudioInputController
+ // objects. The implementation of OnStreamCreated takes ownership.
henrika (OOO until Aug 14) 2013/03/04 13:12:51 Add comments about |length| and |index|.
wjia(left Chromium) 2013/03/05 02:40:13 Done.
+ virtual void OnSharedMemoryCreated(base::SharedMemoryHandle handle,
+ int length,
+ int index) = 0;
+
// Called when state of an audio stream has changed.
virtual void OnStateChanged(State state) = 0;
@@ -76,8 +80,12 @@
// audio |params|. Once the stream has been created, the implementation must
// generate a notification to the AudioInputIPCDelegate and call
// OnStreamCreated().
- virtual void CreateStream(int stream_id, const AudioParameters& params,
- const std::string& device_id, bool automatic_gain_control) = 0;
+ virtual void CreateStream(
+ int stream_id,
+ const AudioParameters& params,
+ const std::string& device_id,
+ bool automatic_gain_control,
+ int shared_memory_count) = 0;
// Starts the device on the server side. Once the device has started,
// or failed to start, a callback to

Powered by Google App Engine
This is Rietveld 408576698