Remove constructors from GrVertexAttrib

Remove constructors from GrVertexAttrib.

It fits our style better to use initializer lists, so the constructors have been removed and replaced with said lists.

[robertphillips, 2013-03-01 19:51:27]

lgtm

[bsalomon, 2013-03-01 19:55:38]

lgtm

https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp#newcode933
src/gpu/GrContext.cpp:933: attribs.push_back(currAttrib);
No need to change but just FYI, this would work:

attribs.push_back()->set(...);

[jvanverth1, 2013-03-01 20:24:00]

> https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp
> File src/gpu/GrContext.cpp (right):
> 
>
https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp#newcode933
> src/gpu/GrContext.cpp:933: attribs.push_back(currAttrib);
> No need to change but just FYI, this would work:
> 
> attribs.push_back()->set(...);

Strangely this seems to generate more assembly in Win64 than what I have.

[commit-bot: I haz the power, 2013-03-01 20:24:23]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/jvanverth@google.com/12379052/1

[commit-bot: I haz the power, 2013-03-01 20:24:26]

Presubmit check for 12379052-1 failed and returned exit status 1.

INFO:root:Found 9 file(s).
Running presubmit commit checks ...
Running /b/commit-queue/workdir/skia/PRESUBMIT.py

** Presubmit Warnings **
Tree state is: caution

***************
Caution: still lots of red
http://skia-tree-status.appspot.com/banner-status?format=json
***************

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[bsalomon, 2013-03-01 20:25:03]

On 2013/03/01 20:24:00, JimVV wrote:
> > https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp
> > File src/gpu/GrContext.cpp (right):
> > 
> >
>
https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp#newcode933
> > src/gpu/GrContext.cpp:933: attribs.push_back(currAttrib);
> > No need to change but just FYI, this would work:
> > 
> > attribs.push_back()->set(...);
> 
> Strangely this seems to generate more assembly in Win64 than what I have.

weird

[jvanverth1, 2013-03-01 20:34:38]

Committed as r7936.

On 2013/03/01 20:25:03, bsalomon wrote:
> On 2013/03/01 20:24:00, JimVV wrote:
> > > https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp
> > > File src/gpu/GrContext.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/12379052/diff/1/src/gpu/GrContext.cpp#newcode933
> > > src/gpu/GrContext.cpp:933: attribs.push_back(currAttrib);
> > > No need to change but just FYI, this would work:
> > > 
> > > attribs.push_back()->set(...);
> > 
> > Strangely this seems to generate more assembly in Win64 than what I have.
> 
> weird