Unify deoptimizer for stub failure trampoline frames.

Unify deoptimizer for stub failure trampoline frames.

This unifies the translation of a compiled stub frame to a stub failure
trampoline frame. Only the frame's register allocation is different on
each architecture and can be factored out.

R=danno@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=13887

[danno, 2013-03-05 13:54:04]

https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc#ne...
src/arm/deoptimizer-arm.cc:557: void
Deoptimizer::FillStubFailureTrampolineFrame(
The name is maybe a little bit misleading. How about How about
DoComputePlatformCompiledStubFrame? The current name suggests that this method
does all the work, when in fact it only does the platform-specific piece.

https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc
File src/arm/frames-arm.cc (right):

https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc#newcode37
src/arm/frames-arm.cc:37: #include "macro-assembler-arm.h"
Why the different includes here compared to other platforms?

[Michael Starzinger, 2013-03-08 11:54:08]

Addressed comments.

https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):

https://codereview.chromium.org/12379045/diff/1/src/arm/deoptimizer-arm.cc#ne...
src/arm/deoptimizer-arm.cc:557: void
Deoptimizer::FillStubFailureTrampolineFrame(
On 2013/03/05 13:54:04, danno wrote:
> The name is maybe a little bit misleading. How about How about
> DoComputePlatformCompiledStubFrame? The current name suggests that this method
> does all the work, when in fact it only does the platform-specific piece.

Done. As discussed offline: IMHO the DoComputeFoo prefix doesn't really apply
here, as it is not generating a frame. How about
SetPlatformCompiledStubRegisters? That includes the indication that it is
platform-specific and that it only sets a few registers.

https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc
File src/arm/frames-arm.cc (right):

https://codereview.chromium.org/12379045/diff/1/src/arm/frames-arm.cc#newcode37
src/arm/frames-arm.cc:37: #include "macro-assembler-arm.h"
On 2013/03/05 13:54:04, danno wrote:
> Why the different includes here compared to other platforms?

Unfortunately the "cp" register is defined as part of the MacroAssembler whereas
all other registers are defined as part of the Assembler on ARM. On the other
architectures all of the registers are defined as part of the Assembler.

[danno, 2013-03-08 15:18:16]

lgtm

[Michael Starzinger, 2013-03-08 16:19:00]

Committed patchset #2 manually as r13887 (presubmit successful).