Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 12379042: Unify deoptimizer for construct stub frames. (Closed)

Created:
7 years, 9 months ago by Michael Starzinger
Modified:
7 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Unify deoptimizer for construct stub frames. This unifies the translation of artificial construct stub frames. The frame layout is almost the same on all architectures and only differs in the presence of a slot holding the constructor function. R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=13843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -477 lines) Patch
M src/arm/deoptimizer-arm.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M src/arm/frames-arm.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +133 lines, -0 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +0 lines, -122 lines 0 comments Download
M src/mips/frames-mips.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
The second step adds an architecture-specific description of the construct stub frame.
7 years, 9 months ago (2013-03-01 12:21:59 UTC) #1
Sven Panne
lgtm
7 years, 9 months ago (2013-03-04 08:43:10 UTC) #2
Michael Starzinger
7 years, 9 months ago (2013-03-06 16:12:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13843 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698