Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 12379041: Quote all arguments when printing a Command (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1000 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 var htmlPath_subtest = _createUrlPathFromFile(new Path(htmlPath)); 1011 var htmlPath_subtest = _createUrlPathFromFile(new Path(htmlPath));
1012 var fullHtmlPath = _getUriForBrowserTest(info, htmlPath_subtest, 1012 var fullHtmlPath = _getUriForBrowserTest(info, htmlPath_subtest,
1013 subtestNames, subtestIndex); 1013 subtestNames, subtestIndex);
1014 1014
1015 List<String> args = <String>[]; 1015 List<String> args = <String>[];
1016 if (TestUtils.usesWebDriver(runtime)) { 1016 if (TestUtils.usesWebDriver(runtime)) {
1017 args = [ 1017 args = [
1018 dartDir.append('tools/testing/run_selenium.py').toNativePath(), 1018 dartDir.append('tools/testing/run_selenium.py').toNativePath(),
1019 '--browser=$runtime', 1019 '--browser=$runtime',
1020 '--timeout=${configuration["timeout"] - 2}', 1020 '--timeout=${configuration["timeout"] - 2}',
1021 '--out="$fullHtmlPath"']; 1021 '--out=$fullHtmlPath'];
1022 if (runtime == 'dartium') { 1022 if (runtime == 'dartium') {
1023 args.add('--executable=$dartiumFilename'); 1023 args.add('--executable=$dartiumFilename');
1024 } 1024 }
1025 if (subtestIndex != 0) { 1025 if (subtestIndex != 0) {
1026 args.add('--force-refresh'); 1026 args.add('--force-refresh');
1027 } 1027 }
1028 commandSet.add(new Command('python', args)); 1028 commandSet.add(new Command('python', args));
1029 } else { 1029 } else {
1030 Expect.isTrue(runtime == "drt"); 1030 Expect.isTrue(runtime == "drt");
1031 1031
(...skipping 906 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 * $pass tests are expected to pass 1938 * $pass tests are expected to pass
1939 * $failOk tests are expected to fail that we won't fix 1939 * $failOk tests are expected to fail that we won't fix
1940 * $fail tests are expected to fail that we should fix 1940 * $fail tests are expected to fail that we should fix
1941 * $crash tests are expected to crash that we should fix 1941 * $crash tests are expected to crash that we should fix
1942 * $timeout tests are allowed to timeout 1942 * $timeout tests are allowed to timeout
1943 * $compileErrorSkip tests are skipped on browsers due to compile-time error 1943 * $compileErrorSkip tests are skipped on browsers due to compile-time error
1944 """; 1944 """;
1945 print(report); 1945 print(report);
1946 } 1946 }
1947 } 1947 }
OLDNEW
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698