Quote all arguments when printing a Command

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 89 matching lines @@
   /** The actual command line that will be executed. */
   String commandLine;
 
   Command(this.executable, this.arguments, [this.environment = null]) {
     if (io.Platform.operatingSystem == 'windows') {
       // Windows can't handle the first command if it is a .bat file or the like
       // with the slashes going the other direction.
       // TODO(efortuna): Remove this when fixed (Issue 1306).
       executable = executable.replaceAll('/', '\\');
     }
-    commandLine = "$executable ${arguments.join(' ')}";
+    var quotedArguments = [];
+    arguments.forEach((argument) => quotedArguments.add('"$argument"'));
+    commandLine = "$executable ${quotedArguments.join(' ')}";
   }
 
   String toString() => commandLine;
 
   Future<bool> get outputIsUpToDate => new Future.immediate(false);
   io.Path get expectedOutputFile => null;
   bool get isPixelTest => false;
 }
 
 class CompilationCommand extends Command {
@@ skipping 175 matching lines @@
 
         // Add any suffixes to the arguments of the original executable.
         var suffixSplit = suffix.split(' ');
         suffixSplit.forEach((e) {
           if (!e.isEmpty) newArguments.add(e);
         });
 
         newArguments.addAll(c.arguments);
         final newCommand = new Command(newExecutablePath, newArguments);
         newCommands.add(newCommand);
-        // If there are extra spaces inside the prefix or suffix, this fails.
-        String expected =
-            '$prefix ${c.executable} $suffix ${c.arguments.join(' ')}';
-        Expect.stringEquals(expected.trim(), newCommand.commandLine);
       }
       commands = newCommands;
     }
   }
 
   CommandOutput get lastCommandOutput {
     if (commandOutputs.length == 0) {
       throw new Exception("CommandOutputs is empty, maybe no command was run? ("
                           "displayName: '$displayName', "
                           "configurationString: '$configurationString')");
@@ skipping 1279 matching lines @@
       if (_verbose && test.commandOutputs.length == 0) {
         int i = 1;
         if (test is BrowserTestCase) {
           // Additional command for rerunning the steps locally after the fact.
           var command =
             test.configuration["_servers_"].httpServerCommandline();
           print('$i. $command');
           i++;
         }
         for (Command command in test.commands) {
-          print('$i. ${command.commandLine}');
+          print('$i. $command');
           i++;
         }
       }
 
       var isLastCommand =
           ((test.commands.length-1) == test.commandOutputs.length);
       var isBrowserCommand = isLastCommand && (test is BrowserTestCase);
       if (isBrowserCommand && _numBrowserProcesses == _maxBrowserProcesses) {
         // If there is no free browser runner, put it back into the queue.
         _tests.add(test);
@@ skipping 128 matching lines @@
           completer.complete(testCase);
         }
       });
     }
     runCommand();
 
     return completer.future;
   }
 }