Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237903002: Let Android use old version of onDrawBitmapRect. (Closed)

Created:
5 years, 5 months ago by scroggo_chromium
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Let Android use old version of onDrawBitmapRect. Define SK_SUPPORT_LEGACY_ONDRAWIMAGERECT when building for the Android framework, since SkiaCanvasProxy overrides the old version of the method. Fixes master-skia build. NOTRY=True Committed: https://skia.googlesource.com/skia/+/b3d54d7c07780db3442d07158c7067900bcf8bce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scroggo
lgtm
5 years, 5 months ago (2015-07-14 20:58:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237903002/1
5 years, 5 months ago (2015-07-14 20:58:42 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 20:59:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b3d54d7c07780db3442d07158c7067900bcf8bce

Powered by Google App Engine
This is Rietveld 408576698