Interfaces for encoded video sources

media/base/encoded_bitstream_buffer.cc

Index: media/base/encoded_bitstream_buffer.cc
diff --git a/media/base/encoded_bitstream_buffer.cc b/media/base/encoded_bitstream_buffer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7bfc46602866ea5db4753aa749ce9aa799128afc
--- /dev/null
+++ b/media/base/encoded_bitstream_buffer.cc
@@ -0,0 +1,127 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/encoded_bitstream_buffer.h"
+
+#include <iomanip>
+
+#include "base/logging.h"
+#include "base/md5.h"
+
+namespace media {
+
+EncodedBitstreamBuffer::EncodedBitstreamBuffer(size_t size,
+                                               base::Time timestamp,
+                                               int temporal_layer)
+    : size_(size), timestamp_(timestamp), key_frame_(false),
+      temporal_layer_(temporal_layer), altref_frame_(false),
+      golden_frame_(false), droppable_(false), layer_sync_(false) {

[wjia(left Chromium), 2013/02/28 18:46:26]

one on each line. refer to
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Constructor_In....

[vmr, 2013/03/01 14:24:00]

Done.

+  ptr_ = new uint8[size_];
+  DCHECK(ptr_);

[wjia(left Chromium), 2013/02/28 18:46:26]

no need to DCHECK.

[vmr, 2013/03/01 14:24:00]

Done.

+}
+
+EncodedBitstreamBuffer::EncodedBitstreamBuffer(uint8* ptr, size_t size,
+                                               base::Time timestamp,
+                                               int temporal_layer)
+    : size_(size), timestamp_(timestamp), key_frame_(false),
+      temporal_layer_(temporal_layer), altref_frame_(false),
+      golden_frame_(false) {

[wjia(left Chromium), 2013/02/28 18:46:26]

ditto.

[vmr, 2013/03/01 14:24:00]

Done.

+  ptr_ = new uint8[size_];
+  DCHECK(ptr_);

[wjia(left Chromium), 2013/02/28 18:46:26]

ditto.

[vmr, 2013/03/01 14:24:00]

Done.

+  memcpy(ptr_, ptr, size);
+}
+
+EncodedBitstreamBuffer::~EncodedBitstreamBuffer() {
+  delete[] ptr_;

[wjia(left Chromium), 2013/02/28 18:46:26]

You don't need this when using scoped_ptr.

[vmr, 2013/03/01 14:24:00]

Done.

+}
+
+uint8* EncodedBitstreamBuffer::ptr() const {
+  return ptr_;
+}
+
+size_t EncodedBitstreamBuffer::size() const {
+  return size_;
+}
+
+base::Time EncodedBitstreamBuffer::timestamp() const {
+  return timestamp_;
+}
+
+int EncodedBitstreamBuffer::temporal_layer() const {
+  return temporal_layer_;
+}
+
+bool EncodedBitstreamBuffer::key_frame() const {
+  return key_frame_;
+}
+
+bool EncodedBitstreamBuffer::altref_frame() const {
+  return altref_frame_;
+}
+
+bool EncodedBitstreamBuffer::golden_frame() const {
+  return golden_frame_;
+}
+
+bool EncodedBitstreamBuffer::droppable() const {
+  return droppable_;
+}
+
+bool EncodedBitstreamBuffer::layer_sync() const {
+  return layer_sync_;
+}
+
+void EncodedBitstreamBuffer::MarkKeyFrame() {
+  key_frame_ = true;
+  altref_frame_ = true;
+  golden_frame_ = true;
+}
+
+void EncodedBitstreamBuffer::MarkAltRef() {
+  altref_frame_ = true;
+}
+
+void EncodedBitstreamBuffer::MarkGolden() {
+  golden_frame_ = true;
+}
+
+void EncodedBitstreamBuffer::MarkDroppable() {
+  droppable_ = true;
+}
+
+void EncodedBitstreamBuffer::MarkLayerSync() {
+  layer_sync_ = true;
+}
+
+}  // namespace media
+
+std::ostream& operator<<(std::ostream& output,
+              const media::EncodedBitstreamBuffer& b) {
+  base::MD5Digest digest;
+  output << "[";
+  if (b.key_frame()) {
+    output << "I";
+  } else {
+    if (b.golden_frame())
+      output << "G";
+    if (b.altref_frame())
+      output << "A";
+    if (b.droppable())
+      output << "-";
+    if (!b.golden_frame() && !b.altref_frame() && !b.droppable())
+      output << "P";
+  }
+  output << "]";
+  output << " tl: [" << b.temporal_layer();
+  if (b.layer_sync())
+    output << "S";
+  output << "]";
+  output << " time: " << std::setprecision(2) << std::fixed
+      << b.timestamp().ToDoubleT();
+  output << " (" << b.size() << " bytes)";
+  base::MD5Sum(b.ptr(), b.size(), &digest);
+  output << " md5: " << base::MD5DigestToBase16(digest);
+  return output;
+}
+