Added chromoting test environment for the tests to share data.

remoting/remoting_test.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //remoting:test_support
       'target_name': 'remoting_test_support',
       'type': 'static_library',
@@ skipping 38 matching lines @@
         'signaling/fake_signal_strategy.cc',
         'signaling/fake_signal_strategy.h',
         'signaling/mock_signal_strategy.cc',
         'signaling/mock_signal_strategy.h',
         'test/access_token_fetcher.cc',
         'test/access_token_fetcher.h',
         'test/app_remoting_report_issue_request.cc',
         'test/app_remoting_report_issue_request.h',
         'test/app_remoting_service_urls.cc',
         'test/app_remoting_service_urls.h',
+        'test/app_remoting_test_driver_environment.cc',
+        'test/app_remoting_test_driver_environment_app_details.cc',

[joedow, 2015/07/16 23:15:38]

Does the ar_test_driver target still build with this app details included here?

[tonychun, 2015/07/16 23:47:55]

Yes it does.

+        'test/app_remoting_test_driver_environment.h',
+        'test/chromoting_test_driver_environment.cc',
+        'test/chromoting_test_driver_environment.h',
+        'test/host_info.cc',
+        'test/host_info.h',
+        'test/host_list_fetcher.cc',
+        'test/host_list_fetcher.h',
         'test/fake_access_token_fetcher.cc',
         'test/fake_access_token_fetcher.h',
         'test/fake_app_remoting_report_issue_request.cc',
         'test/fake_app_remoting_report_issue_request.h',
+        'test/fake_host_list_fetcher.cc',
+        'test/fake_host_list_fetcher.h',
         'test/fake_network_dispatcher.cc',
         'test/fake_network_dispatcher.h',
         'test/fake_network_manager.cc',
         'test/fake_network_manager.h',
         'test/fake_port_allocator.cc',
         'test/fake_port_allocator.h',
+        'test/fake_refresh_token_store.cc',
+        'test/fake_refresh_token_store.h',
         'test/fake_remote_host_info_fetcher.cc',
         'test/fake_remote_host_info_fetcher.h',
         'test/fake_socket_factory.cc',
         'test/fake_socket_factory.h',
         'test/host_info.cc',
         'test/host_info.h',
         'test/host_list_fetcher.cc',
         'test/host_list_fetcher.h',
         'test/leaky_bucket.cc',
         'test/leaky_bucket.h',
@@ skipping 24 matching lines @@
       ],
     },
     {
       'target_name': 'chromoting_test_driver',
       'type': '<(gtest_target_type)',
       'dependencies': [
         'remoting_test_support',
         '../testing/gtest.gyp:gtest',
       ],
       'sources': [
+        'test/chromoting_test_driver_environment.cc',
+        'test/chromoting_test_driver_environment.h',
         'test/chromoting_test_driver.cc',
+        'test/host_info.cc',
+        'test/host_info.h',
+        'test/host_list_fetcher.cc',
+        'test/host_list_fetcher.h',

[joedow, 2015/07/16 23:15:38]

I don't think you need these since they are already included in
remoting_test_support

[tonychun, 2015/07/16 23:47:55]

Removed.

       ],
     }, # end of target 'chromoting_test_driver'
     {
       'target_name': 'ar_test_driver_common',
       'type': 'static_library',
       'dependencies': [
         '../remoting/proto/chromotocol.gyp:chromotocol_proto_lib',
         '../testing/gtest.gyp:gtest',
         '../third_party/webrtc/modules/modules.gyp:desktop_capture',
         'remoting_test_support',
@@ skipping 189 matching lines @@
         'signaling/jid_util_unittest.cc',
         'signaling/log_to_server_unittest.cc',
         'signaling/push_notification_subscriber_unittest.cc',
         'signaling/server_log_entry_unittest.cc',
         'signaling/server_log_entry_unittest.h',
         'signaling/xmpp_login_handler_unittest.cc',
         'signaling/xmpp_stream_parser_unittest.cc',
         'signaling/xmpp_signal_strategy_unittest.cc',
         'test/access_token_fetcher_unittest.cc',
         'test/app_remoting_report_issue_request_unittest.cc',
+        'test/app_remoting_test_driver_environment_unittest.cc',

[joedow, 2015/07/16 23:15:38]

This file is already included (line 359)

[tonychun, 2015/07/16 23:47:55]

Removed.

+        'test/chromoting_test_driver_environment_unittest.cc',
         'test/host_list_fetcher_unittest.cc',
         'test/remote_host_info_fetcher_unittest.cc',
         'test/test_chromoting_client_unittest.cc',
         'test/test_video_renderer_unittest.cc',
 
         # TODO(sergeyu): app_remoting_test_driver_environment_unittest.cc
         # depends on ar_test_driver_common target and that target implicitly
         # depends on app_remoting_test_driver_environment_app_details.cc to
         # allow some parameters to be overridden (i.e. *app_details.cc file can
         # be replace with a different one). This means that app_deails.cc file
@@ skipping 264 matching lines @@
             '../build/isolate.gypi',
           ],
           'sources': [
             'remoting_unittests.isolate',
           ],
         },
       ],
     }],
   ] # end of 'conditions'
 }