Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1237873003: [es6] Fix String.prototype.normalize to properly validate argument (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Fix String.prototype.normalize to properly validate argument BUG=v8:4302 LOG=n Committed: https://crrev.com/9c8f78e26fceae20f0088353b810484cf4d5c8be Cr-Commit-Position: refs/heads/master@{#29683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/i18n.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/string-normalize.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 5 months ago (2015-07-14 20:49:07 UTC) #2
rossberg
lgtm
5 years, 5 months ago (2015-07-15 08:49:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237873003/1
5 years, 5 months ago (2015-07-15 15:12:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 15:15:07 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 15:15:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c8f78e26fceae20f0088353b810484cf4d5c8be
Cr-Commit-Position: refs/heads/master@{#29683}

Powered by Google App Engine
This is Rietveld 408576698