Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1237873002: Fix a compilation with non-clang/non-gcc compilers (Closed)

Created:
5 years, 5 months ago by jungshik at Google
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a compilation with non-clang/non-gcc compilers This is going back to PS #4 in https://codereview.chromium.org/1148463002/ BUG=466959, 508049, 508440 TEST=See bugs TBR=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/ffeeae138703e692f07d2c438203f32b84e7a094

Patch Set 1 #

Patch Set 2 : update the patch, too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M patches/mutex.patch View 1 3 chunks +10 lines, -7 lines 0 comments Download
M source/common/putilimp.h View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
5 years, 5 months ago (2015-07-14 19:46:08 UTC) #1
jungshik at Google
5 years, 5 months ago (2015-07-14 19:48:18 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ffeeae138703e692f07d2c438203f32b84e7a094 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698