src/compiler/js-generic-lowering.cc - Issue 1237813002: Switch CallConstructStub to take new.target in register.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1237813002: Switch CallConstructStub to take new.target in register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments about ARM and MIPS. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/js-generic-lowering.cc

diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc

index 4915b75d06f4d93e009472dcf84c66974e6d9541..84ee3933e22a28ba715417ed7222fdca7aa117bd 100644

--- a/src/compiler/js-generic-lowering.cc

+++ b/src/compiler/js-generic-lowering.cc

@@ -549,9 +549,8 @@ void JSGenericLowering::LowerJSCallConstruct(Node* node) {

node->InsertInput(zone(), 0, stub_code);

node->InsertInput(zone(), 1, jsgraph()->Int32Constant(arity - 2));

node->InsertInput(zone(), 2, actual_construct);

- // TODO(mstarzinger): Pass original constructor in register.

- CHECK_EQ(actual_construct, original_construct);

- node->InsertInput(zone(), 3, jsgraph()->UndefinedConstant());

+ node->InsertInput(zone(), 3, original_construct);

+ node->InsertInput(zone(), 4, jsgraph()->UndefinedConstant());

node->set_op(common()->Call(desc));

}

« no previous file with comments | « src/arm64/interface-descriptors-arm64.cc ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »