Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: src/x64/interface-descriptors-x64.cc

Issue 1237813002: Switch CallConstructStub to take new.target in register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments about ARM and MIPS. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 10
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 CallInterfaceDescriptorData* data) { 164 CallInterfaceDescriptorData* data) {
165 Register registers[] = {rdi, rdx, rbx}; 165 Register registers[] = {rdi, rdx, rbx};
166 data->InitializePlatformSpecific(arraysize(registers), registers); 166 data->InitializePlatformSpecific(arraysize(registers), registers);
167 } 167 }
168 168
169 169
170 void CallConstructDescriptor::InitializePlatformSpecific( 170 void CallConstructDescriptor::InitializePlatformSpecific(
171 CallInterfaceDescriptorData* data) { 171 CallInterfaceDescriptorData* data) {
172 // rax : number of arguments 172 // rax : number of arguments
173 // rbx : feedback vector 173 // rbx : feedback vector
174 // rdx : (only if rbx is not the megamorphic symbol) slot in feedback 174 // rcx : original constructor (for IsSuperConstructorCall)
175 // vector (Smi) 175 // rdx : slot in feedback vector (Smi, for RecordCallTarget)
176 // rdi : constructor function 176 // rdi : constructor function
177 // TODO(turbofan): So far we don't gather type feedback and hence skip the 177 // TODO(turbofan): So far we don't gather type feedback and hence skip the
178 // slot parameter, but ArrayConstructStub needs the vector to be undefined. 178 // slot parameter, but ArrayConstructStub needs the vector to be undefined.
179 Register registers[] = {rax, rdi, rbx}; 179 Register registers[] = {rax, rdi, rcx, rbx};
180 data->InitializePlatformSpecific(arraysize(registers), registers); 180 data->InitializePlatformSpecific(arraysize(registers), registers);
181 } 181 }
182 182
183 183
184 void RegExpConstructResultDescriptor::InitializePlatformSpecific( 184 void RegExpConstructResultDescriptor::InitializePlatformSpecific(
185 CallInterfaceDescriptorData* data) { 185 CallInterfaceDescriptorData* data) {
186 Register registers[] = {rcx, rbx, rax}; 186 Register registers[] = {rcx, rbx, rax};
187 data->InitializePlatformSpecific(arraysize(registers), registers); 187 data->InitializePlatformSpecific(arraysize(registers), registers);
188 } 188 }
189 189
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 rdi, // math rounding function 359 rdi, // math rounding function
360 rdx, // vector slot id 360 rdx, // vector slot id
361 rbx // type vector 361 rbx // type vector
362 }; 362 };
363 data->InitializePlatformSpecific(arraysize(registers), registers); 363 data->InitializePlatformSpecific(arraysize(registers), registers);
364 } 364 }
365 } // namespace internal 365 } // namespace internal
366 } // namespace v8 366 } // namespace v8
367 367
368 #endif // V8_TARGET_ARCH_X64 368 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698