Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: src/ia32/interface-descriptors-ia32.cc

Issue 1237813002: Switch CallConstructStub to take new.target in register. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments about ARM and MIPS. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/interface-descriptors.h" 9 #include "src/interface-descriptors.h"
10 10
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 CallInterfaceDescriptorData* data) { 163 CallInterfaceDescriptorData* data) {
164 Register registers[] = {edi, edx, ebx}; 164 Register registers[] = {edi, edx, ebx};
165 data->InitializePlatformSpecific(arraysize(registers), registers); 165 data->InitializePlatformSpecific(arraysize(registers), registers);
166 } 166 }
167 167
168 168
169 void CallConstructDescriptor::InitializePlatformSpecific( 169 void CallConstructDescriptor::InitializePlatformSpecific(
170 CallInterfaceDescriptorData* data) { 170 CallInterfaceDescriptorData* data) {
171 // eax : number of arguments 171 // eax : number of arguments
172 // ebx : feedback vector 172 // ebx : feedback vector
173 // edx : (only if ebx is not the megamorphic symbol) slot in feedback 173 // ecx : original constructor (for IsSuperConstructorCall)
174 // vector (Smi) 174 // edx : slot in feedback vector (Smi, for RecordCallTarget)
175 // edi : constructor function 175 // edi : constructor function
176 // TODO(turbofan): So far we don't gather type feedback and hence skip the 176 // TODO(turbofan): So far we don't gather type feedback and hence skip the
177 // slot parameter, but ArrayConstructStub needs the vector to be undefined. 177 // slot parameter, but ArrayConstructStub needs the vector to be undefined.
178 Register registers[] = {eax, edi, ebx}; 178 Register registers[] = {eax, edi, ecx, ebx};
179 data->InitializePlatformSpecific(arraysize(registers), registers, NULL); 179 data->InitializePlatformSpecific(arraysize(registers), registers, NULL);
180 } 180 }
181 181
182 182
183 void RegExpConstructResultDescriptor::InitializePlatformSpecific( 183 void RegExpConstructResultDescriptor::InitializePlatformSpecific(
184 CallInterfaceDescriptorData* data) { 184 CallInterfaceDescriptorData* data) {
185 Register registers[] = {ecx, ebx, eax}; 185 Register registers[] = {ecx, ebx, eax};
186 data->InitializePlatformSpecific(arraysize(registers), registers, NULL); 186 data->InitializePlatformSpecific(arraysize(registers), registers, NULL);
187 } 187 }
188 188
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 edi, // math rounding function 359 edi, // math rounding function
360 edx, // vector slot id 360 edx, // vector slot id
361 ebx // type vector 361 ebx // type vector
362 }; 362 };
363 data->InitializePlatformSpecific(arraysize(registers), registers); 363 data->InitializePlatformSpecific(arraysize(registers), registers);
364 } 364 }
365 } // namespace internal 365 } // namespace internal
366 } // namespace v8 366 } // namespace v8
367 367
368 #endif // V8_TARGET_ARCH_IA32 368 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698